Commit 553517df authored by Takashi Iwai's avatar Takashi Iwai Committed by Treehugger Robot
Browse files

UPSTREAM: ASoC: soc-pcm: Move debugfs removal out of spinlock



[ Upstream commit 9f620684 ]

The recent fix for DPCM locking also covered the loop in
dpcm_be_disconnect() with the FE stream lock.  This caused an
unexpected side effect, thought: calling debugfs_remove_recursive() in
the spinlock may lead to lockdep splats as the code there assumes the
SOFTIRQ-safe context.

For avoiding the problem, this patch changes the disconnection
procedure to two phases: at first, the matching entries are removed
from the linked list, then the resources are freed outside the lock.

Bug: 287928097
Bug: 277241308
Fixes: b7898396 ("ASoC: soc-pcm: Fix and cleanup DPCM locking")
Reported-and-tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Change-Id: If812604234dabbe3b3c234b567295c36864b4a89
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20220119155249.26754-3-tiwai@suse.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarWill McVicker <willmcvicker@google.com>
parent 8930f00e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment