ANDROID: sdcardfs: fix -ENOENT lookup race issue
The negative lower dentry created by vfs_path_lookup could be reclaimed between vfs_path_lookup and d_hash_and_lookup. Therefore, it is unsafe to just lookup dcache again for the negative dentry cases. Without this patch, users could occasionally get trapped into `failed to create' under memory pressure. So here is a workaround to hack it and in my opinion sdcardfs should be refactored to close all races in the long term as pointed out in the code comment of this commit. Test: (Thread 1) while true; do echo 3 > /proc/sys/vm/drop_caches done (Thread 2) i=0 while true; do echo 123 > /sdcard/$i i=$((i+1)) done Bug: 63872684 Cc: Daniel Rosenberg <drosen@google.com> Cc: Miao Xie <miaoxie@huawei.com> Cc: Chao Yu <yuchao0@huawei.com> Change-Id: Ic033e1f84a8b271c1f48010f4e1f189982bbbea2 Signed-off-by:Gao Xiang <gaoxiang25@huawei.com> Signed-off-by:
Daniel Rosenberg <drosen@google.com>
Loading
Please sign in to comment