Commit 4d91d2ab authored by Roberto Bergantinos Corpas's avatar Roberto Bergantinos Corpas Committed by Ben Hutchings
Browse files

sunrpc: expiry_time should be seconds not timeval



commit 3d96208c upstream.

When upcalling gssproxy, cache_head.expiry_time is set as a
timeval, not seconds since boot. As such, RPC cache expiry
logic will not clean expired objects created under
auth.rpcsec.context cache.

This has proven to cause kernel memory leaks on field. Using
64 bit variants of getboottime/timespec

Expiration times have worked this way since 2010's c5b29f88 "sunrpc:
use seconds since boot in expiry cache".  The gssproxy code introduced
in 2012 added gss_proxy_save_rsc and introduced the bug.  That's a while
for this to lurk, but it required a bit of an extreme case to make it
obvious.

Signed-off-by: default avatarRoberto Bergantinos Corpas <rbergant@redhat.com>
Fixes: 030d794b "SUNRPC: Use gssproxy upcall for server..."
Tested-By: default avatarFrank Sorenson <sorenson@redhat.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
[bwh: Backported to 3.16: Use struct timespec and getboottime()]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 888865cf
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment