FROMGIT: usb: gadget: uvc: prevent use of disabled endpoint
Currently the set_alt callback immediately disables the endpoint and queues the v4l2 streamoff event. However, as the streamoff event is processed asynchronously, it is possible that the video_pump thread attempts to queue requests to an already disabled endpoint. This change moves disabling usb endpoint to the end of streamoff event callback. As the endpoint's state can no longer be used, video_pump is now guarded by uvc->state as well. To be consistent with the actual streaming state, uvc->state is now toggled between CONNECTED and STREAMING from the v4l2 event callback only. Link: https://lore.kernel.org/20230615171558.GK741@pendragon.ideasonboard.com/ Link: https://lore.kernel.org/20230531085544.253363-1-dan.scally@ideasonboard.com/ Reviewed-by:Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by:
Michael Grzeschik <m.grzeschik@pengutronix.de> Tested-by:
Michael Grzeschik <m.grzeschik@pengutronix.de> Signed-off-by:
Avichal Rakesh <arakesh@google.com> Link: https://lore.kernel.org/r/20231109004104.3467968-1-arakesh@google.com Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Bug: 313502218 Bug: 296925310 (cherry picked from commit 991544dc https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/usb usb-next) Signed-off-by:
Avichal Rakesh <arakesh@google.com> (cherry picked from https://android-review.googlesource.com/q/commit:86d2f598a321fa8258c4f4f5aae4a0e9477d8420) Merged-In: Ic5631a526e72cbcf299dcb8167bb3d34468d37e9 Change-Id: Ic5631a526e72cbcf299dcb8167bb3d34468d37e9
Loading
Please sign in to comment