Commit 4954d297 authored by Deepanshu Kartikey's avatar Deepanshu Kartikey Committed by Greg Kroah-Hartman
Browse files

ext4: detect invalid INLINE_DATA + EXTENTS flag combination



[ Upstream commit 1d3ad183 ]

syzbot reported a BUG_ON in ext4_es_cache_extent() when opening a verity
file on a corrupted ext4 filesystem mounted without a journal.

The issue is that the filesystem has an inode with both the INLINE_DATA
and EXTENTS flags set:

    EXT4-fs error (device loop0): ext4_cache_extents:545: inode #15:
    comm syz.0.17: corrupted extent tree: lblk 0 < prev 66

Investigation revealed that the inode has both flags set:
    DEBUG: inode 15 - flag=1, i_inline_off=164, has_inline=1, extents_flag=1

This is an invalid combination since an inode should have either:
- INLINE_DATA: data stored directly in the inode
- EXTENTS: data stored in extent-mapped blocks

Having both flags causes ext4_has_inline_data() to return true, skipping
extent tree validation in __ext4_iget(). The unvalidated out-of-order
extents then trigger a BUG_ON in ext4_es_cache_extent() due to integer
underflow when calculating hole sizes.

Fix this by detecting this invalid flag combination early in ext4_iget()
and rejecting the corrupted inode.

Cc: stable@kernel.org
Reported-and-tested-by: default avatar <syzbot+038b7bf43423e132b308@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=038b7bf43423e132b308


Suggested-by: default avatarZhang Yi <yi.zhang@huawei.com>
Signed-off-by: default avatarDeepanshu Kartikey <kartikey406@gmail.com>
Reviewed-by: default avatarZhang Yi <yi.zhang@huawei.com>
Message-ID: <20250930112810.315095-1-kartikey406@gmail.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
[ Adjust context ]
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 301c668d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment