Commit 474a540f authored by Major chen's avatar Major chen Committed by Will Deacon
Browse files

ANDROID: irq: put irq_resolve_mapping under protection of __irq_enter_raw



With commit a879ad2f ("ANDROID: genirq: Allow an interrupt to be marked
as 'raw'"), irq_resolve_mapping was moved out of scope between
irq_enter() and irq_exit(). This result in  handle_domain_irq->
irq_resolve_mapping->__irq_resolve_mapping->rcu_read_unlock->
__rcu_read_unlock->rcu_read_unlock_special->in_irq() return false.

Now one RCU stall issue was observed due to IPI_IRQ_WORK irq storm.
IPI_IRQ_WORK irq was triggered from handle_domain_irq->...->
rcu_read_unlock_special->irq_work_queue_on again and again unexpectedly
 due to in_irq() return false even it is in IRQ context.

This patch fix its side effect without reverting commit a879ad2f.
During call path "handle_domain_irq->irq_resolve_mapping->...->
rcu_read_unlock_special()" with use_softirq is true.
1)before this patch, in_irq() is false
  This will result in IPI_IRQ_WORK irq storm due to next IPI_IRQ_WORK irq
will be triggered under IRQ context again and again.
2)after this patch,in_irq() will be true
  RCU_SOFTIRQ will be raised(but not next IPI_IRQ_WORK irq) under IRQ context.

Bug: 261364180
Fixes: a879ad2f ("ANDROID: genirq: Allow an interrupt to be marked as 'raw'")
Change-Id: I447e5718694ebfaa11bfe4ef620d85646d5b49d6
Signed-off-by: default avatarMajor chen <major.chen@samsung.com>
Signed-off-by: default avatarEuiyoul Ryu <ryu.real@samsung.com>
parent aea6e535
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment