UPSTREAM: kbuild: Add -Wa,--fatal-warnings to as-instr invocation
Certain assembler instruction tests may only induce warnings from the assembler on an unsupported instruction or option, which causes as-instr to succeed when it was expected to fail. Some tests workaround this limitation by additionally testing that invalid input fails as expected. However, this is fragile if the assembler is changed to accept the invalid input, as it will cause the instruction/option to be unavailable like it was unsupported even when it is. Use '-Wa,--fatal-warnings' in the as-instr macro to turn these warnings into hard errors, which avoids this fragility and makes tests more robust and well formed. Cc: stable@vger.kernel.org Suggested-by:Eric Biggers <ebiggers@kernel.org> Signed-off-by:
Nathan Chancellor <nathan@kernel.org> Tested-by:
Eric Biggers <ebiggers@google.com> Tested-by:
Andy Chiu <andybnac@gmail.com> Reviewed-by:
Andy Chiu <andybnac@gmail.com> Tested-by:
Conor Dooley <conor.dooley@microchip.com> Reviewed-by:
Conor Dooley <conor.dooley@microchip.com> Acked-by:
Masahiro Yamada <masahiroy@kernel.org> Link: https://lore.kernel.org/r/20240125-fix-riscv-option-arch-llvm-18-v1-1-390ac9cc3cd0@kernel.org Signed-off-by:
Palmer Dabbelt <palmer@rivosinc.com> (cherry picked from commit 0ee695a4) Bug: 332317531 Test: For whole topic: booted kernel in QEMU and ran crypto self-tests Change-Id: Iaef9ed7782815486cef133cd69ad9ba1ff5cce4d Signed-off-by:
Eric Biggers <ebiggers@google.com>
Loading
Please sign in to comment