Commit 3891454f authored by Kees Cook's avatar Kees Cook Committed by Amit Pundir
Browse files

UPSTREAM: bug: switch data corruption check to __must_check

(cherry-picked from 85caa95b)

The CHECK_DATA_CORRUPTION() macro was designed to have callers do
something meaningful/protective on failure.  However, using "return
false" in the macro too strictly limits the design patterns of callers.
Instead, let callers handle the logic test directly, but make sure that
the result IS checked by forcing __must_check (which appears to not be
able to be used directly on macro expressions).

Change-Id: I635dc2f39959104ea8b475d2d5018af3502f33ba
Link: http://lkml.kernel.org/r/20170206204547.GA125312@beast


Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Suggested-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarSatya Tangirala <satyat@google.com>
Signed-off-by: default avatarAmit Pundir <amit.pundir@linaro.org>
parent 6fb418c9
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment