Commit 35c421e8 authored by Sami Tolvanen's avatar Sami Tolvanen Committed by Treehugger Robot
Browse files

UPSTREAM: gendwarfksyms: Fix structure type overrides



As we always iterate through the entire die_map when expanding
type strings, recursively processing referenced types in
type_expand_child() is not actually necessary. Furthermore,
the type_string kABI rule added in commit c9083467
("gendwarfksyms: Add a kABI rule to override type strings") can
fail to override type strings for structures due to a missing
kabi_get_type_string() check in this function.

Fix the issue by dropping the unnecessary recursion and moving
the override check to type_expand(). Note that symbol versions
are otherwise unchanged with this patch.

Bug: 400972353
Change-Id: I374cbce923c8eca310cf921cd3f3ed3b9545279d
Fixes: c9083467 ("gendwarfksyms: Add a kABI rule to override type strings")
Reported-by: default avatarGiuliano Procida <gprocida@google.com>
Signed-off-by: default avatarSami Tolvanen <samitolvanen@google.com>
Reviewed-by: default avatarPetr Pavlu <petr.pavlu@suse.com>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
(cherry picked from commit 2f6b47b2)
Signed-off-by: default avatarSami Tolvanen <samitolvanen@google.com>
parent 511b97bb
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment