Commit 310e1b33 authored by Ryan Ware's avatar Ryan Ware Committed by Greg Kroah-Hartman
Browse files

EVM: Use crypto_memneq() for digest comparisons



commit 613317bd upstream.

This patch fixes vulnerability CVE-2016-2085.  The problem exists
because the vm_verify_hmac() function includes a use of memcmp().
Unfortunately, this allows timing side channel attacks; specifically
a MAC forgery complexity drop from 2^128 to 2^12.  This patch changes
the memcmp() to the cryptographically safe crypto_memneq().

Reported-by: default avatarXiaofei Rex Guo <xiaofei.rex.guo@intel.com>
Signed-off-by: default avatarRyan Ware <ware@linux.intel.com>
Signed-off-by: default avatarMimi Zohar <zohar@linux.vnet.ibm.com>
Signed-off-by: default avatarJames Morris <james.l.morris@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e63603a9
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment