FROMLIST: usb: dwc3: core: Do not perform GCTL_CORE_SOFTRESET during bootup
According to the programming guide, it is recommended to perform a GCTL_CORE_SOFTRESET only when switching the mode from device to host or host to device. However, it is found that during bootup when __dwc3_set_mode() is called for the first time, GCTL_CORESOFTRESET is done with suspendable bit(BIT 17) of DWC3_GUSB3PIPECTL set. This some times leads to issues like controller going into bad state and controller registers reading value zero. Until GCTL_CORESOFTRESET is done and run/stop bit is set core initialization is not complete. Setting suspendable bit of DWC3_GUSB3PIPECTL and then performing GCTL_CORESOFTRESET is therefore not recommended. Avoid this by only performing the reset if current_dr_role is set, that is, when doing subsequent role switching. Fixes: f88359e1 ("usb: dwc3: core: Do core softreset when switch mode") Signed-off-by:Rohith Kollalsi <quic_rkollals@quicinc.com> Bug: 240122498 Link: https://lore.kernel.org/lkml/20220714045625.20377-1-quic_rkollals@quicinc.com/ Change-Id: I3d249b3295bd043b3e492a4f9b771088178f8787 Signed-off-by:
Mayank Rana <quic_mrana@quicinc.com>
Loading
Please sign in to comment