binder: Address corner cases in deferred copy and fixup
When handling BINDER_TYPE_FDA object we are pushing a parent fixup
with a certain skip_size but no scatter-gather copy object, since
the copy is handled standalone.
If BINDER_TYPE_FDA is the last children the scatter-gather copy
loop will never stop to skip it, thus we are left with an item in
the parent fixup list. This will trigger the BUG_ON().
This is reproducible in android when playing a video.
We receive a transaction that looks like this:
obj[0] BINDER_TYPE_PTR, parent
obj[1] BINDER_TYPE_PTR, child
obj[2] BINDER_TYPE_PTR, child
obj[3] BINDER_TYPE_FDA, child
Fixes: 09184ae9 ("binder: defer copies of pre-patched txn data")
Acked-by:
Todd Kjos <tkjos@google.com>
Cc: stable <stable@kernel.org>
Signed-off-by:
Alessandro Astone <ales.astone@gmail.com>
Link: https://lore.kernel.org/r/20220415120015.52684-2-ales.astone@gmail.com
Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Loading
-
mentioned in commit 1e91bb6c
-
mentioned in commit 3d213a62
-
mentioned in commit bba81a12
-
mentioned in commit 3f9db778
-
mentioned in commit b6e2498a
-
mentioned in commit 0663d42a
-
mentioned in commit 3f6c121c
-
mentioned in commit 43e84388
-
mentioned in commit 70bfd66c
-
mentioned in commit 5a08e9fc
-
mentioned in commit 4946f150
-
mentioned in commit 596e9834
-
mentioned in commit 8348e701
-
mentioned in commit 8b752fff
-
mentioned in commit 162a7ef3
-
mentioned in commit 6921d6a4
-
mentioned in commit 37390b7c
-
mentioned in commit b37d454d
-
mentioned in commit 762bbfbd
Please sign in to comment