Commit 2c7af1c5 authored by Pietro Borrello's avatar Pietro Borrello Committed by Lee Jones
Browse files

UPSTREAM: HID: bigben_worker() remove unneeded check on report_field



[ Upstream commit 27d2a2fd ]

bigben_worker() checks report_field to be non-NULL.
The check has been added in commit
918aa1ef ("HID: bigbenff: prevent null pointer dereference")
to prevent a NULL pointer crash.
However, the true root cause was a missing check for output
reports, patched in commit
c7bf714f ("HID: check empty report_list in bigben_probe()"),
where the type-confused report list_entry was overlapping with
a NULL pointer, which was then causing the crash.

Bug: 268589017
Fixes: 918aa1ef ("HID: bigbenff: prevent null pointer dereference")
Signed-off-by: default avatarPietro Borrello <borrello@diag.uniroma1.it>
Link: https://lore.kernel.org/r/20230125-hid-unregister-leds-v4-2-7860c5763c38@diag.uniroma1.it


Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarLee Jones <joneslee@google.com>
Change-Id: Ide36490e2e4482f6cf9af931bef052f172419e31
parent b6f02ec3
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment