Commit 1e9aba62 authored by Saubhik Mukherjee's avatar Saubhik Mukherjee Committed by Lee Jones
Browse files

net: appletalk: cops: Fix data race in cops_probe1



[ Upstream commit a4dd4fc6 ]

In cops_probe1(), there is a write to dev->base_addr after requesting an
interrupt line and registering the interrupt handler cops_interrupt().
The handler might be called in parallel to handle an interrupt.
cops_interrupt() tries to read dev->base_addr leading to a potential
data race. So write to dev->base_addr before calling request_irq().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarSaubhik Mukherjee <saubhik.mukherjee@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarLee Jones <joneslee@google.com>
Change-Id: If8cf646212ac849f504650265a9ad8f25f2fb462
parent 211547cf
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment