Commit 11ff5e06 authored by André Draszik's avatar André Draszik Committed by Bartosz Golaszewski
Browse files

gpiolib: devres: release GPIOs in devm_gpiod_put_array()



devm_gpiod_put_array() is meant to undo the effects of
devm_gpiod_get_array() - in particular, it should release the GPIOs
contained in the array acquired with the latter. It is meant to be the
resource-managed version of gpiod_put_array(), and it should behave
similar to the non-array version devm_gpiod_put().

Since commit d1d52c66 ("gpiolib: devres: Finish the conversion to
use devm_add_action()") it doesn't do that anymore, it just removes the
devres action and frees associated memory, but it doesn't actually
release the GPIOs.

Fix by switching from devm_remove_action() to devm_release_action(),
which will in addition invoke the action to release the GPIOs.

Fixes: d1d52c66 ("gpiolib: devres: Finish the conversion to use devm_add_action()")
Signed-off-by: default avatarAndré Draszik <andre.draszik@linaro.org>
Reported-by: default avatarWattson CI <wattson-external@google.com>
Reported-by: default avatarSamuel Wu <wusamuel@google.com>
Link: https://lore.kernel.org/r/20250715-gpiolib-devres-put-array-fix-v1-1-970d82a8c887@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent e31c8f1d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment