gfs2: Fix LM_FLAG_TRY* logic in add_to_queue
The logic in add_to_queue() for determining whether a LM_FLAG_TRY or LM_FLAG_TRY_1CB holder should be queued does not make any sense: we are interested in wether or not the new operation will block behind an existing or future holder in the queue, but the current code checks for ongoing locking or ->go_inval() operations, which has little to do with that. Replace that code with something more sensible, remove the incorrect add_to_queue() function annotations, remove the similarly misguided do_error(gl, 0) call in do_xmote(), and add a missing comment to the same call in do_promote(). Signed-off-by:Andreas Gruenbacher <agruenba@redhat.com> Reviewed-by:
Andrew Price <anprice@redhat.com>
Loading
Please sign in to comment