igc: fix PTM cycle trigger logic
[ Upstream commit 8e404ad9 ] Writing to clear the PTM status 'valid' bit while the PTM cycle is triggered results in unreliable PTM operation. To fix this, clear the PTM 'trigger' and status after each PTM transaction. The issue can be reproduced with the following: $ sudo phc2sys -R 1000 -O 0 -i tsn0 -m Note: 1000 Hz (-R 1000) is unrealistically large, but provides a way to quickly reproduce the issue. PHC2SYS exits with: "ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM transaction fails This patch also fixes a hang in igc_probe() when loading the igc driver in the kdump kernel on systems supporting PTM. The igc driver running in the base kernel enables PTM trigger in igc_probe(). Therefore the driver is always in PTM trigger mode, except in brief periods when manually triggering a PTM cycle. When a crash occurs, the NIC is reset while PTM trigger is enabled. Due to a hardware problem, the NIC is subsequently in a bad busmaster state and doesn't handle register reads/writes. When running igc_probe() in the kdump kernel, the first register access to a NIC register hangs driver probing and ultimately breaks kdump. With this patch, igc has PTM trigger disabled most of the time, and the trigger is only enabled for very brief (10 - 100 us) periods when manually triggering a PTM cycle. Chances that a crash occurs during a PTM trigger are not 0, but extremely reduced. Fixes: a90ec848 ("igc: Add support for PTP getcrosststamp()") Reviewed-by:Michal Swiatkowski <michal.swiatkowski@linux.intel.com> Tested-by:
Mor Bar-Gabay <morx.bar.gabay@intel.com> Tested-by:
Avigail Dahan <avigailx.dahan@intel.com> Signed-off-by:
Christopher S M Hall <christopher.s.hall@intel.com> Reviewed-by:
Corinna Vinschen <vinschen@redhat.com> Signed-off-by:
Jacob Keller <jacob.e.keller@intel.com> Tested-by:
Vinicius Costa Gomes <vinicius.gomes@intel.com> Signed-off-by:
Tony Nguyen <anthony.l.nguyen@intel.com> Signed-off-by:
Sasha Levin <sashal@kernel.org>
Loading