i2c: mediatek: fix potential incorrect use of I2C_MASTER_WRRD
[ Upstream commit b4921836 ] The old IC does not support the I2C_MASTER_WRRD (write-then-read) function, but the current code’s handling of i2c->auto_restart may potentially lead to entering the I2C_MASTER_WRRD software flow, resulting in unexpected bugs. Instead of repurposing the auto_restart flag, add a separate flag to signal I2C_MASTER_WRRD operations. Also fix handling of msgs. If the operation (i2c->op) is I2C_MASTER_WRRD, then the msgs pointer is incremented by 2. For all other operations, msgs is simply incremented by 1. Fixes: b2ed11e2 ("I2C: mediatek: Add driver for MediaTek MT8173 I2C controller") Signed-off-by:Leilk.Liu <leilk.liu@mediatek.com> Suggested-by:
Chen-Yu Tsai <wenst@chromium.org> Reviewed-by:
Chen-Yu Tsai <wenst@chromium.org> Signed-off-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by:
Sasha Levin <sashal@kernel.org>
Loading
Please sign in to comment