FROMLIST: binder: check offset alignment in binder_get_object()
Commit 6d98eb95 ("binder: avoid potential data leakage when copying txn") introduced changes to how binder objects are copied. In doing so, it unintentionally removed an offset alignment check done through calls to binder_alloc_copy_from_buffer() -> check_buffer(). These calls were replaced in binder_get_object() with copy_from_user(), so now an explicit offset alignment check is needed here. This avoids later complications when unwinding the objects gets harder. It is worth noting this check existed prior to commit 7a67a393 ("binder: add function to copy binder object from buffer"), likely removed due to redundancy at the time. Fixes: 6d98eb95 ("binder: avoid potential data leakage when copying txn") Cc: <stable@vger.kernel.org> Acked-by:Todd Kjos <tkjos@google.com> Signed-off-by:
Carlos Llamas <cmllamas@google.com> Bug: 334156990 Bug: 320661088 Link: https://lore.kernel.org/all/20240330190115.1877819-1-cmllamas@google.com/ Signed-off-by:
Carlos Llamas <cmllamas@google.com> (cherry picked from https://android-review.googlesource.com/q/commit:d76a750f6ffe72431a2c467e85a5ac69366287d1) Merged-In: Iaddabaa28de7ba7b7d35dbb639d38ca79dbc5077 Change-Id: Iaddabaa28de7ba7b7d35dbb639d38ca79dbc5077
Loading
-
mentioned in commit 9116864d
-
mentioned in commit e6bddd08
-
mentioned in commit cb8a2055
-
mentioned in commit 35185dde
-
mentioned in commit 4012159c
-
mentioned in commit cfdeec99
-
mentioned in commit 005b9bf1
-
mentioned in commit 7a67c43e
-
mentioned in commit 9e27cba3
-
mentioned in commit 99da58e4
-
mentioned in commit d6cb479a
-
mentioned in commit c0c2926f
-
mentioned in commit d6f4ad89
Please sign in to comment