Commit 5c17cb6f authored by taeju.park's avatar taeju.park Committed by Android Partner Code Review
Browse files

usb: gadget: Fix g_ether interface link status



A "usb0" interface that has never been connected to a host has an unknown
operstate, and therefore the IFF_RUNNING flag is (incorrectly) asserted
when queried by ifconfig, ifplugd, etc.  This is a result of calling
netif_carrier_off() too early in the probe function; it should be called
after register_netdev().

Similar problems have been fixed in many other drivers, e.g.:

e826eafa (bonding: Call netif_carrier_off after register_netdevice)
0d672e9f (drivers/net: Call netif_carrier_off at the end of the probe)
6a3c869a (cxgb4: fix reported state of interfaces without link)

Fix is to move netif_carrier_off() to the end of the function.

Change-Id: Idf42a032774d652eeb1acb83df9d90789c10e183

Cc: stable@vger.kernel.org
Signed-off-by: default avatarKevin Cernekee <cernekee@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 2870d8d1
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment