UPSTREAM: cpufreq: qcom-kryo: Fix section annotations
There is currently a warning when building the Kryo cpufreq driver into the kernel image: WARNING: vmlinux.o(.text+0x8aa424): Section mismatch in reference from the function qcom_cpufreq_kryo_probe() to the function .init.text:qcom_cpufreq_kryo_get_msm_id() The function qcom_cpufreq_kryo_probe() references the function __init qcom_cpufreq_kryo_get_msm_id(). This is often because qcom_cpufreq_kryo_probe lacks a __init annotation or the annotation of qcom_cpufreq_kryo_get_msm_id is wrong. Remove the '__init' annotation from qcom_cpufreq_kryo_get_msm_id so that there is no more mismatch warning. Additionally, Nick noticed that the remove function was marked as '__init' when it should really be marked as '__exit'. Fixes: 46e2856b (cpufreq: Add Kryo CPU scaling driver) Fixes: 5ad7346b (cpufreq: kryo: Add module remove and exit) Reported-by:Nick Desaulniers <ndesaulniers@google.com> Signed-off-by:
Nathan Chancellor <natechancellor@gmail.com> Acked-by:
Viresh Kumar <viresh.kumar@linaro.org> Cc: 4.18+ <stable@vger.kernel.org> # 4.18+ Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> (cherry picked from commit d51aea13 https://github.com/torvalds/linux.git ) Signed-off-by:
Niklas Cassel <niklas.cassel@linaro.org> BUG=b:129558664 TEST=Validate DVFS and schedutil governor Git-repo: https://git.linaro.org/people/niklas.cassel/kernel.git Git-commit: bbe6cabfdd405c07ab5fe72c17385e018303f578 Signed-off-by:
Praveen Koya <pkoya@codeaurora.org> Change-Id: I91f7c444fcb20e26a402d6398ade76b9e5abd101 Signed-off-by:
Vamsi Singamsetty <vamssi@codeaurora.org> Signed-off-by:
Khasim Syed Mohammed <khasim.mohammed@linaro.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1664368 Reviewed-by:
Zhihong Yu <zhihongyu@chromium.org> Reviewed-by:
Sean Paul <seanpaul@chromium.org> Commit-Queue: Zhihong Yu <zhihongyu@chromium.org> Tested-by:
Zhihong Yu <zhihongyu@chromium.org>
Loading
Please sign in to comment