- Nov 17, 2018
-
-
Treehugger Robot authored
-
Tri Vo authored
cgroup is labeled from genfs_contexts. Also, cgroup filesystems can't be context mounted, i.e. it's not possible to mount them with a label other than "cgroup". Bug: 110962171 Test: m selinux_policy Test: boot aosp_walleye Change-Id: I8319b10136c42a42d1edaee47b77ad1698e87f2c
-
Tri Vo authored
-
Treehugger Robot authored
-
- Nov 16, 2018
-
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Robert Carr authored
Add an InputFlinger service in system_server and allow SurfaceFlinger to exchange sockets with it. Test: None Bug: 80101428 Bug: 113136004 Bug: 111440400 Change-Id: I1533ab7a1da0ca61d8a28037fffbc189d796f737
-
Tri Vo authored
With Treble, cameraserver no longer depends on camera devices directly. Moreover, pixel 3 doesn't have /dev/cam node. We still keep "camera_device" type around since vendor policy uses it to label its /dev nodes. Bug: 110962171 Test: boot aosp_walleye Test: camera app still works Change-Id: If12d640c2a0006b9fc3c9f6704285eb8eb66c626
-
Yiwei Zhang authored
Changed the GPU service name back to be compatible with external engines/tools' usage of vkjson cmd. Bug: 118347356 Test: adb shell cmd gpu vkjson Change-Id: Ie432fd8be63d33070ad037c509467c8367b42d39
-
Nick Kralevich authored
Auditallow added in commit 72edbb3e ("Audit generic debugfs access for removal", May 01 2018) has not triggered. Remove allow rule and tighten up neverallow rule. Test: policy compiles Test: no collected SELinux denials. Change-Id: I9a90463575f9eab4711b72d6f444fa9d526b80e1
-
Joel Galenson authored
This will be needed if vendors remove a label, as vendor_init would need to relabel from it (which would be unlabeled) to the new label. Test: Build policy. Change-Id: Ieea0fcd7379da26b2864b971f7773ed61f413bb9
-
Treehugger Robot authored
-
Jiyong Park authored
Label the surfaceflinger binary as surfaceflinger_exec Test: m apex.test; m; device is bootable Change-Id: I22297ba514f7ba298a1d0d4b476a447f26e48078
-
Nick Kralevich authored
1b1d133b added the process2 class but forgot to suppress SELinux denials associated with these permissions for the su domain. Suppress them. Ensure xdp_socket is in socket_class_set, so the existing dontaudit rule in su.te is relevant. Inspired by https://github.com/SELinuxProject/refpolicy/commit/66a337eec6d7244e44e51936835b4e904f275a02 Add xdp_socket to various other neverallow rules. Test: policy compiles. Change-Id: If5422ecfa0cc864a51dd69559a51d759e078c8e7
-
Nick Kralevich authored
Remove the special case that allowed init to relabel app_data_file and privapp_data_file. The auditallow added in ab82125f has never triggered. Bug: 80190017 Test: policy compiles Test: no SELinux denials collected for the auditallow rule Change-Id: Ide7c31e1a0628464ec2fcf041e8975087c39166d
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Nick Kralevich authored
It is unnecessary to use get_prop() rules for the su domain. The su domain is always in permissive mode [1] and not subject to SELinux enforcement. It's also possible these rules were added to avoid SELinux denial log spam from showing up, however, there are already dontaudit rules in place [2] to prevent this. Delete the unnecessary rules. [1] https://android.googlesource.com/platform/system/sepolicy/+/96b62a60c2ccae777fdcabe7d2ed28b52056860b/private/su.te#19 [2] https://android.googlesource.com/platform/system/sepolicy/+/96b62a60c2ccae777fdcabe7d2ed28b52056860b/public/su.te#42 Test: policy compiles Change-Id: I5913f360738725bf915f0606d381029b9ba4318f
-
Treehugger Robot authored
-
Kevin Chyn authored
Test: vold is able to create directories, ag/5534962 Bug: 116528212 Change-Id: I61dd8802c13b1c42d334a80b678ca6a877848fc2
-
- Nov 15, 2018
-
-
Tri Vo authored
We lose git history with this, but imo the rules being moved don't have much reference material. Also, as we write more neverallow rules for CKI, I'd like to consolidate them in private/coredomain.te Test: m selinux_policy Change-Id: I6d0c3d2af0c4dfe7dd3cb1d8836b4b5e00db37a4
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Tri Vo authored
kmem_device was used to label /dev/mem and /dev/kmem. We already have multiple layers of protection against those /dev nodes being present on devices. CTS checks that /dev/mem and /dev/kmem don't exist: https://android.googlesource.com/platform/cts/+/master/tests/tests/permission/src/android/permission/cts/FileSystemPermissionTest.java#233 VTS enforces our base kernel configs, which have CONFIG_DEVKMEM and CONFIG_DEVMEM disabled: https://android.googlesource.com/kernel/configs/+/master/android-4.9/android-base.config#2 Bug: 110962171 Test: m selinux_policy Change-Id: I246740684218dee0cddf81dabf84d4763a753cde
-
Treehugger Robot authored
-
Yifan Hong authored
-
Nick Kralevich authored
Used by https://android.googlesource.com/platform/external/ipsec-tools/+/bf16586a33b1432a11526754523fceb62944dc1c/main.c#116 Addresses the following denial: audit(0.0:8126): avc: denied { ioctl } for comm="racoon" path="/dev/tun" dev="tmpfs" ino=25329 ioctlcmd=0x54ca scontext=u:r:racoon:s0 tcontext=u:object_r:tun_device:s0 tclass=chr_file permissive=0 Test: policy compiles. Change-Id: Ia26077d4a9e810c7006d4b979d6b7e9ca154b485
-
Treehugger Robot authored
-
Mårten Kongstad authored
Bug: 78815803 Test: builds, boots Test: manual: adb shell idmap2 create ... Test: manual: adb shell ps | grep -e idmap2d Change-Id: I60852e15d99329896ff9de6559d1e7cd1c67e33d
-
Nick Kralevich authored
Commit 619c1ef2 ("tun_device: enforce ioctl restrictions") completely removed the ability of untrusted apps to issue ioctl calls to tun_device. It turns out that this was too aggressive. Wireshark apparently uses the TUNGETIFF ioctl. Fixes the following denial: audit(0.0:384744): avc: denied { ioctl } for comm=4173796E635461736B202332 path="/dev/tun" dev="tmpfs" ino=19560 ioctlcmd=54d2 scontext=u:r:untrusted_app:s0:c51,c257,c512,c768 tcontext=u:object_r:tun_device:s0 tclass=chr_file permissive=1 app=com.wireguard.android Test: policy compiles. Change-Id: I71bb494036ea692781c00af37580748ab39d1332
-
Yifan Hong authored
These ioctls are similar to BLKGETSIZE64; they return benign information about the partition's alignment, and are used by liblp to optimally align dynamic partition extents. The system_block_device is included here because on retrofit devices, the "super" partition is mapped to the system partition. Test: manual OTA on retrofit device Bug: 118506262 Change-Id: I3dd3c99d86d63f97bcd393cff374e27f5ed2da2e
-
- Nov 14, 2018
-
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Nick Kralevich authored
BLKDISCARD is used by vold while wiping block devices https://android.googlesource.com/platform/system/vold/+/b2455747a92957d109a050b8f3e394d87d085086/Utils.cpp#619 BLKGETSIZE is used to determine the size of the block device. Ideally code should not be using this ioctl, as it fails for devices >= 2T in size. Vold indirectly uses this when executing /system/bin/newfs_msdos. Arguably this is a bug in newfs_msdos, as BLKGETSIZE64 should be used instead. Code: https://android.googlesource.com/platform/external/newfs_msdos/+/0c7e133c7fde67911efb7bd920d4f0ab0c269af8/mkfs_msdos.c#845 Addresses the following denials: audit(0.0:24): avc: denied { ioctl } for comm="Binder:588_2" path="/dev/block/vold/public:7,9" dev="tmpfs" ino=106407 ioctlcmd=1277 scontext=u:r:vold:s0 tcontext=u:object_r:vold_device:s0 tclass=blk_file permissive=0 audit(0.0:25): avc: denied { ioctl } for comm="newfs_msdos" path="/dev/block/vold/public:7,9" dev="tmpfs" ino=106407 ioctlcmd=1260 scontext=u:r:vold:s0 tcontext=u:object_r:vold_device:s0 tclass=blk_file permissive=0 Test: policy compiles. Bug: 119562530 Change-Id: Ib7198daf150d6f2578545a6a402e0313069ea2b4
-
Tomasz Wasilczyk authored
This enables native wireless interface configuration at boot. Bug: 36120314 Test: adb shell ifconfig -a | grep wlan Change-Id: I797c0c8a8645d690d311f42cec3998b2f4cee77b
-
Florian Mayer authored
-
Treehugger Robot authored
-
Florian Mayer authored
Test: m Test: flash sailfish Test: profile system_server Change-Id: I577793af655146ee91be86bb286fcf9d6e6d081d
-