Skip to content
Snippets Groups Projects
  1. Aug 11, 2017
    • Nick Kralevich's avatar
      Validate no-cross-domain /proc/PID access · 881fe06f
      Nick Kralevich authored
      am: 7a463809
      
      Change-Id: Iba80938afccd21f0c3b69626223b35c672358e77
      881fe06f
    • Nick Kralevich's avatar
      Validate no-cross-domain /proc/PID access · 7a463809
      Nick Kralevich authored
      Android uses hidepid=2 to restrict visibility to other /proc entries on
      the system. This helps preserve user, application, and system
      confidentiality by preventing unauthorized access to application metadata,
      and addresses attacks such as
      http://www.cs.ucr.edu/~zhiyunq/pub/sec14_android_activity_inference.pdf
      
      Ensure the SELinux (weaker) equivalent is being enforced by adding
      neverallow compile time assertions.
      
      TODO: The "shell" user runs as both an Android application, as well as
      spawned via adb shell. This was a mistake. We should separate out the
      "shell" Android app into it's own SELinux domain. For now, exclude the
      shell from this assertion. (The shell Android app is covered by
      hidepid=2, so there's no leaking of data, but still, it's over
      privileged today and should be cleaned up.
      
      Bug: 23310674
      Test: policy compiles. Compile time assertion only.
      Change-Id: I0e1a6506b2719aabf7eb8127f046c4ada947ba90
      7a463809
  2. Aug 02, 2017
  3. Aug 01, 2017
    • Manoj Gupta's avatar
      Fix static analyzer warnings. · 3cdd4a4b
      Manoj Gupta authored
      Fix the following warnings:
      
      system/sepolicy/tools/sepolicy-analyze/neverallow.c:346:9: warning:
      Potential leak of memory pointed to by '__s1'
      system/sepolicy/tools/sepolicy-analyze/neverallow.c:346:9: warning:
      Potential leak of memory pointed to by 'id'
      system/sepolicy/tools/sepolicy-analyze/neverallow.c:364:13: warning:
      Potential leak of memory pointed to by 'classperms'
      system/sepolicy/tools/sepolicy-analyze/neverallow.c:364:13: warning:
      Potential leak of memory pointed to by 'node'
      
      Bug: b/27101951
      Test:Warnings are gone.
      Change-Id: Ib9b2e0b9f19950b4b764d438ee58340e6c022ef5
      3cdd4a4b
    • Ruchi Kandoi's avatar
      Allow nfc application to set nfc property · 7ceea484
      Ruchi Kandoi authored
      am: df964950
      
      Change-Id: I5e793a78ad471b27fdc0bb88596ab23f6ac43dc4
      7ceea484
  4. Jul 31, 2017
    • Ruchi Kandoi's avatar
      Allow nfc application to set nfc property · df964950
      Ruchi Kandoi authored
      type=1400 audit(1501520483.066:14): avc: denied { write } for pid=3330
      comm=4173796E635461736B202331 name="property_service" dev="tmpfs"
      ino=10749 scontext=u:r:nfc:s0 tcontext=u:object_r:property_socket:s0
      tclass=sock_file permissive=0
      
      Test: No sepolicy denials
      Bug: 64010793
      Change-Id: I8d73e8e19cd4d0a8c61f1f184820c53e5cc2b6d6
      df964950
  5. Jul 29, 2017
  6. Jul 28, 2017
  7. Jul 27, 2017
    • Jeff Vander Stoep's avatar
      domain_deprecated: remove sysfs rules · 8e589af6
      Jeff Vander Stoep authored
      am: 275f6dd5
      
      Change-Id: I02b2eb1a5bbd0cf3a4bbeffbe70e442ba4cf8ee6
      8e589af6
    • Tim Kryger's avatar
      Fix selinux denials during bugreport · b7e1f2dd
      Tim Kryger authored
      
      avc: denied { read } for pid=1704 comm="top" name="stat" dev="proc" ino=4026532297 scontext=u:r:dumpstate:s0 tcontext=u:object_r:proc_stat:s0 tclass=file permissive=0
      avc: denied { read } for pid=1636 comm="dumpstate" name="lcd-backlight" dev="sysfs" ino=16592 scontext=u:r:dumpstate:s0 tcontext=u:object_r:sysfs_leds:s0 tclass=lnk_file permissive=0
      avc: denied { call } for pid=2230 comm="dumpsys" scontext=u:r:dumpstate:s0 tcontext=u:r:installd:s0 tclass=binder permissive=0
      avc: denied { create } for pid=1700 comm="ip" scontext=u:r:dumpstate:s0 tcontext=u:r:dumpstate:s0 tclass=netlink_xfrm_socket permissive=0
      
      Bug: 62410287
      Bug: 35350306
      Change-Id: I65be3678c64214ebeb544e0e155bce88b21adf02
      Signed-off-by: default avatarTim Kryger <tkryger@google.com>
      b7e1f2dd
    • Jeff Vander Stoep's avatar
      domain_deprecated: remove sysfs rules · 275f6dd5
      Jeff Vander Stoep authored
      Clean up the remaining granted permissions in domain_deprecated.
      
      avc: granted { read open } for comm="uncrypt"
      path="/sys/firmware/devicetree/base/firmware/android/fstab/compatible"
      dev="sysfs" ino=17591 scontext=u:r:uncrypt:s0
      tcontext=u:object_r:sysfs:s0 tclass=file
      avc: granted { getattr } for comm="uncrypt"
      path="/sys/firmware/devicetree/base/firmware/android/compatible"
      dev="sysfs" ino=17583 scontext=u:r:uncrypt:s0
      tcontext=u:object_r:sysfs:s0 tclass=file
      
      vc: granted { read open } for comm="update_engine"
      path="/sys/firmware/devicetree/base/firmware/android/fstab" dev="sysfs"
      ino=17258 scontext=u:r:update_engine:s0 tcontext=u:object_r:sysfs:s0
      tclass=dir
      avc: granted { getattr } for comm="update_engine"
      path="/sys/firmware/devicetree/base/firmware/android/fstab/compatible"
      dev="sysfs" ino=17259 scontext=u:r:update_engine:s0
      tcontext=u:object_r:sysfs:s0 tclass=file
      
      Bug: 28760354
      Test: build
      Change-Id: Id318ce84894c1001361923f5205de093a15c1e6a
      275f6dd5
    • Jeffrey Vander Stoep's avatar
      Merge "netd: relax binder neverallow rules for hwservices" · d7989e8b
      Jeffrey Vander Stoep authored
      am: 4fc64f2f
      
      Change-Id: I7dd6ea7bb5d767afb98a39e56214dd05d4585c93
      d7989e8b
    • Jeffrey Vander Stoep's avatar
    • Joel Galenson's avatar
      Add missing comment from my previous merge in 47966cec. · 87e51162
      Joel Galenson authored
      Test: Built.
      Change-Id: Ia5f5b52e10e9411cd87901053675d9e77a622529
      87e51162
    • Joel Galenson's avatar
      resolve merge conflicts of 27c0aa7a to stage-aosp-master · 47966cec
      Joel Galenson authored
      Test: I solemnly swear I tested this conflict resolution.
      
      Merged-In: Ia28707ec565a0792bc882fbffe9e8ab9968535f5
      Change-Id: I1f087fe5e7a71761a16673331619f52998473b44
      47966cec
    • Jeff Vander Stoep's avatar
      netd: relax binder neverallow rules for hwservices · 07c650eb
      Jeff Vander Stoep authored
      Relax neverallow rule restricting binder access to/from netd so that
      netd can export hwbinder services to vendor components.
      
      Continue to disallow app access to netd via binder.
      
      Bug: 36682246
      Test: build
      Change-Id: I8e558ea1add6c36b966ec1da204062ea82df3f3f
      07c650eb
    • Joel Galenson's avatar
      Move file labeling to genfs_contexts. · 27c0aa7a
      Joel Galenson authored
      This should improve performance, as file_contexts is slower than
      genfs_contexts.
      
      Bug: 62413700
      Test: Built, flashed, and booted Sailfish.  Verified that the
      files have the correct context and that wifi, web, and atrace work.
      
      Merged-In: Ia28707ec565a0792bc882fbffe9e8ab9968535f5
      Change-Id: I9546f3af3c95e3443684ae4764881b69987611ef
      27c0aa7a
  8. Jul 26, 2017
    • Jeff Vander Stoep's avatar
      Merge "cgroup: allow associate to tmpfs" · 1bc17b61
      Jeff Vander Stoep authored
      am: 5a30eadc
      
      Change-Id: I02b0984e1ecb119e2793d01a950e2e643d3ea5c8
      1bc17b61
    • Treehugger Robot's avatar
      5a30eadc
    • Jeff Vander Stoep's avatar
      Merge "system_server: read symlinks in /cache" · 3d765cfd
      Jeff Vander Stoep authored
      am: 825173e3
      
      Change-Id: Ic7acb327cf684e6b82b1d40b408c039e02c0a7fd
      3d765cfd
    • Treehugger Robot's avatar
      825173e3
    • Jeff Vander Stoep's avatar
      cgroup: allow associate to tmpfs · 5dcaa67b
      Jeff Vander Stoep authored
      Allows groups to be mounted at /dev/memcg
      
      Addresses:
      avc: denied { associate } for comm="init" name="memcg"
      scontext=u:object_r:cgroup:s0 tcontext=u:object_r:tmpfs:s0
      tclass=filesystem permissive=0
      
      Bug: 64067152
      Test: build
      Change-Id: Ic8f641e841fe09c8f7fd487ed67cf0ab4860a1cc
      5dcaa67b
    • Jeff Vander Stoep's avatar
      system_server: read symlinks in /cache · a4cada74
      Jeff Vander Stoep authored
      type=1400 audit(0.0:6): avc: denied { read } for comm="Thread-5"
      name="cache" dev="dm-0" ino=13 scontext=u:r:system_server:s0
      tcontext=u:object_r:cache_file:s0 tclass=lnk_file permissive=0
      
      Bug: 64067152
      Test: build
      Change-Id: Ie90c0343a834aa87b7ded41f503e05d9b63b3244
      a4cada74
    • Jeff Vander Stoep's avatar
      domain_deprecated: remove proc access · ad95219c
      Jeff Vander Stoep authored
      am: c15d54ef
      
      Change-Id: I5b47e2ced9dd5aa92727076e4cef0cc4ebaeaf7c
      ad95219c
    • Jeff Vander Stoep's avatar
      domain_deprecated: remove proc access · c15d54ef
      Jeff Vander Stoep authored
      Remove "granted" logspam. Grante the observed permissions to the
      individual processes that need them and remove the permission from
      domain_deprecated.
      
      avc: granted { read open } for comm="ndroid.settings"
      path="/proc/version" dev="proc" ino=4026532081
      scontext=u:r:system_app:s0 tcontext=u:object_r:proc:s0 tclass=file
      avc: granted { getattr } for comm=4173796E635461736B202332
      path="/proc/pagetypeinfo" dev="proc" ino=4026532129
      scontext=u:r:system_app:s0 tcontext=u:object_r:proc:s0 tclass=file
      
      avc: granted { read open } for comm="uncrypt" path="/proc/cmdline"
      dev="proc" ino=4026532072 scontext=u:r:uncrypt:s0
      tcontext=u:object_r:proc:s0 tclass=file
      
      avc: granted { read open } for comm="update_engine"
      path="/proc/sys/kernel/random/boot_id" dev="proc" ino=15852829
      scontext=u:r:update_engine:s0 tcontext=u:object_r:proc:s0 tclass=file
      
      avc: granted { read open } for comm="tiveportallogin"
      path="/proc/vmstat" dev="proc" ino=4026532130
      scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:proc:s0
      tclass=file
      
      This change is specifically not granting the following since it
      should not be allowed:
      avc: granted { read open } for comm="crash_dump64"
      path="/proc/filesystems" dev="proc" ino=4026532416
      scontext=u:r:dex2oat:s0 tcontext=u:object_r:proc:s0 tclass=file
      avc: granted { read } for comm="crash_dump64" name="filesystems"
      dev="proc" ino=4026532416 scontext=u:r:dex2oat:s0
      tcontext=u:object_r:proc:s0 tclass=file
      avc: granted { getattr } for comm="crash_dump64"
      path="/proc/filesystems" dev="proc" ino=4026532416
      scontext=u:r:dex2oat:s0 tcontext=u:object_r:proc:s0 tclass=file
      
      Bug: 64032843
      Bug: 28760354
      Test: build
      Change-Id: Ib309e97b6229bdf013468dca34f606c0e8da96d0
      c15d54ef
  9. Jul 25, 2017
  10. Jul 24, 2017
Loading