Skip to content
Snippets Groups Projects
  1. Sep 24, 2014
    • Nick Kralevich's avatar
      allow apps to read the contents of mounted OBBs · 62083414
      Nick Kralevich authored
      Apps should be able to read the contents of mounted OBBs.
      
      Steps to reproduce:
      
        1) Install com.namcobandaigames.soulcaliburgp (SoulCalibur)
        2) Attempt to run the app.
      
      Expected:
        App runs successfully.
      
      Actual:
        App crashes. See denials below.
      
      This can also be reproduced by running the newly introduced CTS
      test in I2018b63b0236ce6b5aee4094e40473315b1948c3
      
      Addresses the following denials:
      
        avc: denied { read } for pid=4133 comm="roidJUnitRunner" name="test1.txt" dev="loop0" ino=23 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:vfat:s0 tclass=file
        avc: denied { open } for pid=4133 comm="roidJUnitRunner" name="test1.txt" dev="loop0" ino=23 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:vfat:s0 tclass=file
        avc: denied { getattr } for pid=4133 comm="roidJUnitRunner" path="/mnt/obb/f73da56689d166b5389d49ad31ecbadb/test1.txt" dev="loop0" ino=23 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:vfat:s0 tclass=file
        avc: denied { search } for name="/" dev="loop0" ino=1 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:vfat:s0 tclass=dir permissive=0
      
      Bug: 17633509
      Change-Id: I49b722b24c1c7d9ab084ebee7c1e349d8d660ffa
      62083414
  2. Sep 23, 2014
    • Nick Kralevich's avatar
      relax appdomain efs_file neverallow rules [DO NOT MERGE] · a8b651bf
      Nick Kralevich authored
      During factory provisioning, some manufacturers may need to pull files
      from /factory (label efs_file and bluetooth_efs_file) to collect
      device specific identifiers such as the mac address, using commands
      similar to the following:
      
        adb shell cat /factory/ssn
        adb shell cat /factory/bt/bd_addr.conf
        adb shell cat /factory/wifi/mac.txt
        adb shell cat /factory/60isn
      
      read-only access to these files is currently disallowed by a
      neverallow rule. Relax the rules to allow read-only access to the
      shell user if desired.
      
      No new SELinux rules are added or deleted by this change. This is
      only a relaxation in what's allowed for vendor specific policy.
      
      Bug: 17600278
      
      (cherry picked from commit 200a9f0e)
      
      Change-Id: I2e277b1068a35cc06e0973df994ec3a49f2c26e7
      a8b651bf
  3. Sep 22, 2014
    • Vineeta Srivastava's avatar
      sepolicy for oem cutomization · b4fcaeea
      Vineeta Srivastava authored
      Added read permissions for bootanimation
      
      Bug: 16635599
      Change-Id: Ib5d0ba5a6d1144ff831f4f0eda092879f853c376
      b4fcaeea
    • Nick Kralevich's avatar
      relax neverallow rules on NETLINK_KOBJECT_UEVENT sockets · 36fb1f1b
      Nick Kralevich authored
      Netlink uevent sockets are used by the kernel to inform userspace
      when certain events occur, for example, when new hardware is added
      or removed. This allows userspace to take some action based on those
      messages.
      
      Relax the neverallow rule for NETLINK_KOBJECT_UEVENT sockets.
      Certain device specific app domains, such as system_app, may have a
      need to receive messages from this socket type.
      
      Continue to neverallow NETLINK_KOBJECT_UEVENT sockets for untrusted_app.
      These sockets have been the source of rooting attacks in Android
      in the past, and it doesn't make sense to expose this to untrusted_apps.
      
      No new SELinux rules are introduced by this change. This is an
      adjustment of compile time assertions only.
      
      Bug: 17525863
      
      (cherry picked from commit 642b8042)
      
      Change-Id: I35f3dc8b1ead9f427645a13fb202e760d1e68e64
      36fb1f1b
  4. Sep 20, 2014
  5. Sep 16, 2014
  6. Sep 13, 2014
  7. Sep 10, 2014
    • Tyler Gunn's avatar
      Renaming Telecomm to Telecom. · 69cdca91
      Tyler Gunn authored
      - Changing package from android.telecomm to android.telecom
      - Changing package from com.android.telecomm to
      com.android.server.telecomm.
      - Renaming TelecommManager to TelecomManager.
      
      Bug: 17364651
      Change-Id: I70e9ecdab7482327f25387ecc6223f46e9cbe10e
      69cdca91
  8. Sep 09, 2014
    • dcashman's avatar
    • dcashman's avatar
      Enable selinux read_policy for adb pull. · 309cc668
      dcashman authored
      Remove permission from appdomain.
      
      Bug: 16866291
      
      Change-Id: I37936fed33c337e1ab2816258c2aff52700af116
      309cc668
    • Nick Kralevich's avatar
      Allow kernel thread to read app data files · b0a99513
      Nick Kralevich authored
      When vold mounts an OBB on behalf of another application, the kernel
      spins up the "loop0" thread to perform the mount operation. Grant
      the kernel thread the ability to read app data files, so the mount
      operation can succeed.
      
      Steps to reproduce:
      
        1) Run: runtest --path cts/tests/tests/os/src/android/os/storage/cts/StorageManagerTest.java
      
      Expected:
      
        1) All tests pass
      
      Actual:
      
        Test failure, with the following error message:
      
        loop0   : type=1400 audit(0.0:46): avc: denied { read } for path="/data/data/com.android.cts.stub/files/test1.obb" dev="mmcblk0p16" ino=115465 scontext=u:r:kernel:s0 tcontext=u:object_r:app_data_file:s0 tclass=file permissive=0
        Vold    : Image mount failed (I/O error)
        MountService: Couldn't mount OBB file: -1
        StorageManager: Received message.  path=/data/data/com.android.cts.stub/files/test1.obb, state=21
        TestRunner: failed: testMountAndUnmountObbNormal(android.os.storage.cts.StorageManagerTest)
        TestRunner: ----- begin exception -----
        TestRunner: junit.framework.AssertionFailedError: OBB should be mounted
        TestRunner:    at junit.framework.Assert.fail(Assert.java:50)
        TestRunner:    at junit.framework.Assert.assertTrue(Assert.java:20)
        TestRunner:    at android.os.storage.cts.StorageManagerTest.mountObb(StorageManagerTest.java:235)
      
      Bug: 17428116
      Change-Id: Id1a39a809b6c3942ff7e08884b40e3e4eec73b6a
      b0a99513
  9. Sep 08, 2014
    • dcashman's avatar
      Add support for factory reset protection. · 47bd7300
      dcashman authored
      Address the following denials:
      <12>[  417.732129] type=1400 audit(365340.189:47): avc: denied { read } for pid=1737 comm="Binder_2" name="mmcblk0p18" dev="tmpfs" ino=12406 scontext=u:r:system_server:s0 tcontext=u:object_r:block_device:s0 tclass=blk_file permissive=0
      <12>[  417.882126] type=1400 audit(365340.339:48): avc: denied { read } for pid=1737 comm="Binder_2" name="mmcblk0p18" dev="tmpfs" ino=12406 scontext=u:r:system_server:s0 tcontext=u:object_r:block_device:s0 tclass=blk_file permissive=0
      
      Bug: 16710840
      Change-Id: I8cb5b4b17dffe14f0bf05d63eb8f6ab8d5c09f53
      47bd7300
  10. Sep 04, 2014
    • Nick Kralevich's avatar
      sdcardd: grant unmount · abfd427a
      Nick Kralevich authored
      If the sdcard daemon is restarted (crash or otherwise), one of the first
      things it attempts to do is umount the previously mounted /mnt/shell/emulated
      fuse filesystem, which is denied by SELinux with the following denial:
      
        sdcard  : type=1400 audit(0.0:6997): avc: denied { unmount } for scontext=u:r:sdcardd:s0 tcontext=u:object_r:fuse:s0 tclass=filesystem permissive=0
      
      Allow the operation.
      
      Steps to reproduce:
      
        1) adb shell into the device and su to root
        2) run "kill -9 [PID OF SDCARD]
      
      Expected:
      
        sdcard daemon successfully restarts without error message.
      
      Actual:
      
        SELinux denial above, plus attempts to mount a new filesystem
        on top of the existing filesystem.
      
      Bug: 17383009
      Change-Id: I386bfc98e2b5b32b1d11408f7cfbd6e3c1af68f4
      abfd427a
  11. Sep 01, 2014
    • Mark Salyzyn's avatar
      logd: permit app access to clear logs · bcdff890
      Mark Salyzyn authored
      I/auditd(19949): type=1400 audit(0.0:71): avc:  denied  { write } for  comm="logcat" name="logd" dev="tmpfs" ino=5924 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:logd_socket:s0 tclass=sock_file
      
      (cherry picked from 60f0be84)
      
      Bug: 17323719
      Change-Id: Id8399195196ffad884eef98030d544c68ed0596f
      bcdff890
  12. Aug 29, 2014
  13. Aug 27, 2014
    • dcashman's avatar
    • dcashman's avatar
      Add permissive domains check to sepolicy-analyze. · c30dd63f
      dcashman authored
      Also enable global reading of kernel policy file. Motivation for this is to
      allow read access to the kernel version of the binary selinux policy.
      
      Bug: 17288791
      
      Change-Id: I1eefb457cea1164a8aa9eeb7683b3d99ee56ca99
      c30dd63f
    • Nick Kralevich's avatar
      support kernel writes to external SDcards · 28b26bcf
      Nick Kralevich authored
      The kernel, when it creates a loop block device, starts a new
      kernel thread "loop0" (drivers/block/loop.c). This kernel thread,
      which performs writes on behalf of other processes, needs read/write
      privileges to the sdcard. Allow it.
      
      Steps to reproduce:
      0) Get device with external, removable sdcard
      1) Run: "adb install -s foo.apk"
      
      Expected:
      
        APK installs successfully.
      
      Actual:
      
        APK fails to install. Error message:
      
          Vold  E  Failed to write superblock (I/O error)
          loop0  W  type=1400 audit(0.0:3123): avc: denied { read } for path="/mnt/secure/asec/smdl1645334795.tmp.asec" dev="mmcblk1p1" ino=528 scontext=u:r:kernel:s0 tcontext=u:object_r:vfat:s0 tclass=file permissive=0
          PackageHelper  E  Failed to create secure container smdl1645334795.tmp
          DefContainer  E  Failed to create container smdl1645334795.tmp
      
      Bug: 17158723
      
      (cherry picked from commit 4c6b1350)
      
      Change-Id: Iea727ac7958fc31d85a037ac79badbe9c85693bd
      28b26bcf
    • dcashman's avatar
      Allow appdomain read perms on apk_data_files. · 711895db
      dcashman authored
      Address:
      type=1400 audit(0.0:103): avc: denied { read } for name="arm" dev="mmcblk0p28" ino=195471 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:apk_data_file:s0 tclass=dir
      
      Bug: 16204150
      Change-Id: I8bf0172b26b780c110c0d95c691785143acd7dd2
      711895db
  14. Aug 19, 2014
    • dcashman's avatar
      DO NOT MERGE. Allow debuggerd read access to shared_relro files. · 85f255b8
      dcashman authored
      Addresses the following denial when debuggerd attempts to stat Webview mmap'd
      shared relro files on process crash.  Full read permissions may not be necessary:
      
      W/debuggerd(  185): type=1400 audit(0.0:97): avc: denied { search } for name="shared_relro" dev="mmcblk0p28" ino=618955 scontext=u:r:debuggerd:s0 tcontext=u:object_r:shared_relro_file:s0 tclass=dir
      
      Bug: 17101854
      Change-Id: I11eea85668ba033c554e5aab99b70a454fb75164
      85f255b8
  15. Aug 15, 2014
  16. Aug 06, 2014
  17. Aug 07, 2014
    • dcashman's avatar
      DO NOT MERGE. Allow untrusted_app access to temporary apk files. · 1c1eb869
      dcashman authored
      Before actual installation, apks are put in a staging area where they are
      scanned by a verifier before completing the install flow.  This verifier runs as
      a priv-app, which is in the untrusted_app domain.  Allow untrusted_app
      read-access to these files.
      
      Bug: 16515815
      
      Change-Id: Ifedc12a33b1f53b62f45013e7b253dbc79b02a4e
      1c1eb869
  18. Aug 06, 2014
  19. Jul 30, 2014
    • Stephen Smalley's avatar
      Fix neverallow rules to eliminate CTS SELinuxTest warnings. · d990a78f
      Stephen Smalley authored
      
      Fix two neverallow rules that yield Invalid SELinux context
      warnings from the CTS SELinuxTest.
      
      For transitions from app domains, we only need to check
      { domain -appdomain } (i.e. domains other than app domains),
      not ~appdomain (i.e. all types other than app domains).  Otherwise
      SELinuxTest tries to generate contexts with the r role and
      non-domain types for testing since the target class is process,
      and such contexts are invalid.
      
      For keeping file_type and fs_type exclusive, we only need to
      check associate permission, not all filesystem permissions, as
      only associate takes a file type as the source context.  Otherwise
      SELinuxTest tries to generate contexts with the r role and
      non-domain types for testing filesystem permissions other than
      associate, since the source of such checks is normally a process
      context.
      
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      
      (cherry picked from commit 21ada26d)
      
      Change-Id: I3346584da9b89f352864dcc30dde06d6bf42e98e
      d990a78f
  20. Jul 29, 2014
  21. Jul 28, 2014
  22. Jul 25, 2014
    • Narayan Kamath's avatar
      Revert "fix system_server dex2oat exec" · aa8e657e
      Narayan Kamath authored
      This reverts commit 10370f5f.
      
      The underlying issue has been fixed and the system_server
      will now go via installd to get stuff compiled, if required.
      
      bug: 16317188
      
      Change-Id: I77a07748a39341f7082fb9fc9792c4139c90516d
      aa8e657e
    • Nick Kralevich's avatar
      Allow sdcardd to read /data/.layout_version · 792d8650
      Nick Kralevich authored
      As described in the system/core commit with the same Change-Id,
      there's a race condition between installd and sdcard when it
      comes to accessing /data/media. Resolve the race by checking
      /data/.layout_version to make sure the filesystem has been upgraded.
      
      Maybe indirectly fixes the following SELinux denial:
      
        sdcard  : type=1400 audit(0.0:3): avc: denied { write } for name="media" dev="mmcblk0p17" ino=102753 scontext=u:r:sdcardd:s0 tcontext=u:object_r:system_data_file:s0 tclass=dir
      
      Bug: 16329437
      Change-Id: I5e164f08009c1036469f8734ec07cbae9c5e262b
      792d8650
  23. Jul 24, 2014
  24. Jul 22, 2014
  25. Jul 18, 2014
  26. Jul 21, 2014
  27. Jul 18, 2014
Loading