Skip to content
Snippets Groups Projects
  1. Apr 18, 2018
    • Jeff Vander Stoep's avatar
      Protect dropbox service data with selinux · 4d3ee1a5
      Jeff Vander Stoep authored
      Create a new label for /data/system/dropbox, and neverallow direct
      access to anything other than init and system_server.
      
      While all apps may write to the dropbox service, only apps with
      android.permission.READ_LOGS, a signature|privileged|development
      permission, may read them. Grant access to priv_app, system_app,
      and platform_app, and neverallow access to all untrusted_apps.
      
      Bug: 31681871
      Test: atest CtsStatsdHostTestCases
      Test: atest DropBoxTest
      Test: atest ErrorsTests
      Change-Id: Ice302b74b13c4d66e07b069c1cdac55954d9f5df
      4d3ee1a5
  2. Apr 17, 2018
    • Tri Vo's avatar
      Sepolicy for rw mount point for vendors. · 8c1a1b24
      Tri Vo authored
      Bug: 64905218
      Test: device boots with /mnt/vendor present and selinux label
      mnt_vendor_file applied correctly.
      Change-Id: Ib34e2859948019d237cf2fe8f71845ef2533ae27
      Merged-In: Ib34e2859948019d237cf2fe8f71845ef2533ae27
      (cherry picked from commit 210a805b)
      8c1a1b24
  3. Apr 13, 2018
    • Jeff Sharkey's avatar
      Add exFAT support; unify behind "sdcard_type". · 000cafc7
      Jeff Sharkey authored
      We're adding support for OEMs to ship exFAT, which behaves identical
      to vfat.  Some rules have been manually enumerating labels related
      to these "public" volumes, so unify them all behind "sdcard_type".
      
      Test: atest
      Bug: 67822822
      Change-Id: I09157fd1fc666ec5d98082c6e2cefce7c8d3ae56
      000cafc7
    • Jaekyun Seok's avatar
      Whitelist vendor-init-settable bluetooth_prop and wifi_prop · 224921d1
      Jaekyun Seok authored
      Values of the following properties are set by SoC vendors on some
      devices including Pixels.
      - persist.bluetooth.a2dp_offload.cap
      - persist.bluetooth.a2dp_offload.enable
      - persist.vendor.bluetooth.a2dp_offload.enable
      - ro.bt.bdaddr_path
      - wlan.driver.status
      
      So they should be whitelisted for compatibility.
      
      Bug: 77633703
      Test: succeeded building and tested with Pixels
      Change-Id: Ib2b81bcc1fd70ddd571dc7fb2b923b576d62b7d5
      224921d1
  4. Apr 09, 2018
    • Max Bires's avatar
      Adding labeling for vendor security patch prop · 5cac1aa9
      Max Bires authored
      This will allow adb shell getprop ro.vendor.build.security_patch to
      properly return the correct build property, whereas previously it was
      offlimits due to lack of label.
      
      Test: adb shell getprop ro.vendor.build.security_patch successfully
      returns whatever VENDOR_SECURITY_PATCH is defined to be in the Android
      .mk files
      
      Change-Id: Ie8427738125fc7f909ad8d51e4b76558f5544d49
      5cac1aa9
  5. Apr 03, 2018
    • Jeff Vander Stoep's avatar
      Rename qtaguid_proc to conform to name conventions · bdf2a9c4
      Jeff Vander Stoep authored
      Test: build
      Bug: 68774956
      Change-Id: I0f9fd87eb41e67e14f35e49eba13e3d1de745250
      bdf2a9c4
    • Jeff Vander Stoep's avatar
      Add untrusted_app_27 · 3aa7ca56
      Jeff Vander Stoep authored
      This is a partial cherry pick of commit 6231b4d9
      'Enforce per-app data protections for targetSdk 28+'.
      
      Untrusted_app_27 remains unreachable, but it's existence
      prevents future merge conflicts.
      
      Bug: 63897054
      Test: build/boot aosp_walleye-userdebug
      Change-Id: I64b013874fe87b55f47e817a1279e76ecf86b7c0
      Merged-In: I64b013874fe87b55f47e817a1279e76ecf86b7c0
      (cherry picked from commit 6231b4d9)
      3aa7ca56
  6. Mar 27, 2018
    • Jaekyun Seok's avatar
      Allow vendor-init-settable to persist.radio.multisim.config · ac8c6e3d
      Jaekyun Seok authored
      A default value of persist.radio.multisim.config can be set by SoC
      vendors, and so vendor-init-settable should be allowed to it.
      
      Bug: 73871799
      Test: succeeded building and tested with taimen
      Change-Id: Ie62b91e7e3d7e05425b742838417f1cab7b3fed4
      ac8c6e3d
  7. Mar 26, 2018
    • Primiano Tucci's avatar
      Revert "Allow system server to set persist.traced.enable" · 4f673cf4
      Primiano Tucci authored
      This reverts commit 6f2040f8.
      
      Reason for revert: not needed anymore after ag/3773705
      This was meant to allow system_server toggling the property on/off.
      Later we realized that we needed a separate property for that 
      (see discussion in b/76077784) and system server happens to
      have already permissions to write to sys.* properties even without
      this CL.
      Reverting because at this point this creates just unnecessary clutter.
      
      Change-Id: Ia73d000aad3c4288a5652047dfe10896e231b0b1
      Test: perfetto_integrationtests
      Bug: 76077784
      4f673cf4
  8. Mar 22, 2018
    • Primiano Tucci's avatar
      Fix selinux brekage on user for atrace · 68240241
      Primiano Tucci authored
      Follow up to aosp/635599. It broke user builds again
      despite being tree hugged because of b/74344625.
      Adding missing ignore entries.
      
      Bug: b/73340039
      Change-Id: Iba195d571aec9579195d79d4970f760e417608c6
      68240241
  9. Mar 20, 2018
  10. Mar 19, 2018
    • Hector Dearman's avatar
      Allow system server to set persist.traced.enable · 6f2040f8
      Hector Dearman authored
      To enable/disable the traced and traced_probes deamons remotely we would
      like system server to be able to set persist.traced.enable.
      See also ag/3736001.
      
      Denial:
      selinux: avc: denied { set } for
      property=persist.traced.enable
      pid=1606 uid=1000 gid=1000
      scontext=u:r:system_server:s0
      tcontext=u:object_r:default_prop:s0 tclass=property_service
      permissive=0\x0a
      
      Run:
      $ adb shell 'ps -A | grep traced'
      Should see traced.
      $ adb shell 'settings put global sys_traced 0'
      $ adb shell 'ps -A | grep traced'
      Should no longer see traced.
      
      Test: See above.
      Change-Id: I245b7df3853cabeb0e75db41fb4facaa178ab8f1
      6f2040f8
  11. Mar 16, 2018
  12. Mar 12, 2018
    • Amit Mahajan's avatar
      Revert "Revert "Move rild from public to vendor."" · 3007344d
      Amit Mahajan authored
      This reverts commit 016f0a58.
      
      Reason for revert: Was temporarily reverted, merging back in with fix.
      
      Test: Basic telephony sanity, treehugger
      Bug: 74486619
      Bug: 36427227
      Merged-in: Ide68726a90d5485c2758673079427407aee1e4f2
      Change-Id: Ide68726a90d5485c2758673079427407aee1e4f2
      (cherry picked from commit 312248ff)
      3007344d
    • Amit Mahajan's avatar
      Revert "Move rild from public to vendor." · 58758dc2
      Amit Mahajan authored
      This reverts commit aed57d4e.
      
      Reason for revert: This CL is expected to break pre-submit tests (b/74486619)
      
      Merged-in: I103c3faa1604fddc27b3b4602b587f2d733827b1
      Change-Id: I0eb7a744e0d43ab15fc490e7e7c870d0f44e1401
      58758dc2
  13. Mar 10, 2018
    • Amit Mahajan's avatar
      Move rild from public to vendor. · aed57d4e
      Amit Mahajan authored
      Also change the neverallow exceptions to be for hal_telephony_server
      instead of rild.
      
      Test: Basic telephony sanity, treehugger
      Bug: 36427227
      Merged-in: If892b28416d98ca1f9c241c5fcec70fbae35c82e
      Change-Id: If892b28416d98ca1f9c241c5fcec70fbae35c82e
      aed57d4e
  14. Mar 07, 2018
    • Ruchi Kandoi's avatar
      Add secure_element_device · ea3cf000
      Ruchi Kandoi authored
      Test: eSE initializes at boot
      Bug: 64881253
      Change-Id: Ib2388b7368c790c402c000adddf1488bee492cce
      ea3cf000
    • Kenny Root's avatar
      Add ADB system service · 0b79a179
      Kenny Root authored
      ADB is being separated from USB service since it's not tied to the USB
      transport. This duplicates the usb_service's settings to adb_service for
      this purpose.
      
      Bug: 63820489
      Test: make
      Change-Id: Idbcfbe470d7568f9cba51f0c8d4a8ee9503db93d
      0b79a179
  15. Feb 23, 2018
    • Robert Sesek's avatar
      Remove rules for starting the webview_zygote as a child of init. · 869562e9
      Robert Sesek authored
      The webview_zygote is now launched as a child-zygote process from the
      main zygote process.
      
      Bug: 63749735
      Test: m
      Test: Launch "Third-party licenses" activity from Settings, and it
            renders correctly via the WebView.
      Merged-In: I9c948b58a969d35d5a5add4b6ab62b8f990645d1
      Change-Id: I153476642cf14883b0dfea0d9f5b3b5e30ac1c08
      869562e9
  16. Feb 08, 2018
    • Jeff Vander Stoep's avatar
      label /data/vendor{_ce,_de} · d25ccabd
      Jeff Vander Stoep authored
      Restrictions introduced in vendor init mean that new devices
      may not no longer exempt vendor init from writing to system_data_file.
      This means we must introduce a new label for /data/vendor which
      vendor_init may write to.
      
      Bug: 73087047
      Test: build and boot Taimen and Marlin. Complete SUW, enroll fingerprint
          No new denials.
      
      Change-Id: I65f904bb28952d4776aab947515947e14befbe34
      d25ccabd
  17. Feb 05, 2018
  18. Feb 01, 2018
  19. Jan 29, 2018
    • Ruchi Kandoi's avatar
      SE Policy for Secure Element app and Secure Element HAL · 8a2b4a78
      Ruchi Kandoi authored
      Test: App startup on boot
      Change-Id: I7740aafc088aadf676328e3f1bb8db5175d97102
      8a2b4a78
    • Primiano Tucci's avatar
      SELinux policies for Perfetto cmdline client (/system/bin/perfetto) · 1a9f4f7a
      Primiano Tucci authored
      Instead of having statsd linking the perfetto client library
      and talk directly to its socket, we let just statsd exec()
      the /system/bin/perfetto cmdline client.
      
      There are two reasons for this:
      1) Simplify the interaction between statsd and perfetto, reduce
        dependencies, binary size bloat and isolate faults.
      2) The cmdline client also takes care of handing the trace to
        Dropbox. This allows to expose the binder interaction surface
        to the short-lived cmdline client and avoid to grant binder
        access to the perfetto traced daemon.
      
      This cmdline client will be used by:
       - statsd
       - the shell user (for our UI and Studio)
      
      Bug: 70942310
      Change-Id: I8cdde181481ad0a1a5cae5937ac446cedac54a1f
      1a9f4f7a
  20. Jan 24, 2018
    • Janis Danisevskis's avatar
      Added default policy for Confirmation UI HAL · 97c56bdd
      Janis Danisevskis authored
      Bug: 63928580
      Test: Manually tested.
      
      Change-Id: If6bb10cb7c009883d853e46dcdeb92cd33877d53
      97c56bdd
    • Marissa Wall's avatar
      sepolicy: restrict access to uid_cpupower files · dfe063c3
      Marissa Wall authored
      Do not let apps read /proc/uid_cpupower/time_in_state,
      /proc/uid_cpupower/concurrent_active_time,
      /proc/uid_cpupower/concurrent_policy_time.
      
      b/71718257
      
      Test: Check that they can't be read from the shell
          without root permissions and system_server was able
          to read them
      
      Change-Id: I812694adfbb4630f7b56aa7096dc2e6dfb148b15
      dfe063c3
    • Joel Galenson's avatar
      Fix init error trying to access file. · cf391269
      Joel Galenson authored
      Init tries to write /proc/sys/vm/min_free_order_shift but fails due to
      a SELinux denial.  This gives the file a new label and gives init the
      ability to write it.
      
      Test: Build and booted Sailfish (a couple of days ago).
      Change-Id: Ic93862b85c468afccff2019d84b927af9ed2a84d
      cf391269
  21. Jan 23, 2018
  22. Jan 22, 2018
    • Max Bires's avatar
      Adding write permissions to traceur · 35c36389
      Max Bires authored
      Fixing denials that stopped traceur from being able to write to
      debugfs_tracing. Also cleaning up general find denials for services that
      traceur doesn't have permission to access.
      
      Additionally, labeling /data/local/trace as a trace_data_file in order
      to give traceur a UX friendly area to write its traces to now that it
      will no longer be a shell user. It will be write/readable by traceur,
      and deletable/readable by shell.
      
      Test: Traceur functionality is not being blocked by selinux policy
      Bug: 68126425
      Change-Id: I201c82975a31094102e90bc81454d3c2a48fae36
      35c36389
    • Steven Moreland's avatar
      Add policy for 'blank_screen'. · 8bda3dfa
      Steven Moreland authored
      This util allows init to turn off the screen
      without any binder dependencies.
      
      Bug: 70846424
      Test: manual + init use
      Change-Id: I4f41a966d6398e959ea6baf36c2cfe6fcebc00de
      8bda3dfa
  23. Jan 20, 2018
  24. Jan 19, 2018
    • Tao Bao's avatar
      Add rules for system_update service. · d7d9cfca
      Tao Bao authored
      system_update service manages system update information: system updater
      (priv_app) publishes the pending system update info through the service,
      while other apps can read the info accordingly (design doc in
      go/pi-ota-platform-api).
      
      This CL adds the service type, and grants priv_app to access the service.
      
      Bug: 67437079
      Test: Build and flash marlin image. The system_update service works.
      Change-Id: I7a3eaee3ecd3e2e16b410413e917ec603566b375
      d7d9cfca
    • Badhri Jagan Sridharan's avatar
      hal_usb_gadget sepolicy · 7bee33e6
      Badhri Jagan Sridharan authored
      Bug: 63669128
      Test: Checked for avc denail messages.
      Change-Id: I057b3cf9ccc945cb943b9cf60fc9cd6c023eddda
      Merged-In: I057b3cf9ccc945cb943b9cf60fc9cd6c023eddda
      7bee33e6
  25. Jan 17, 2018
    • Chenbo Feng's avatar
      Add sepolicy to lock down bpf access · 566411ed
      Chenbo Feng authored
      Add a new set of sepolicy for the process that only netd use to load
      and run ebpf programs. It is the only process that can load eBPF
      programs into the kernel and is only used to do that. Add some
      neverallow rules regarding which processes have access to bpf objects.
      
      Test: program successfully loaded and pinned at sys/fs/bpf after device
      boot. No selinux violation for bpfloader
      Bug: 30950746
      
      Change-Id: Ia6bb1afda29ae0749bdc368e2dfc5faa12e81b2f
      566411ed
  26. Jan 16, 2018
  27. Jan 11, 2018
    • Jeff Vander Stoep's avatar
      relabel files in /proc/net/xt_qtaguid/ · 43303c8b
      Jeff Vander Stoep authored
      /proc/net/xt_qtaguid is used by apps to track their network data
      use. Limit access to just zygote spawned processes - apps and
      system_server, omitting access to isolated_app which is not allowed
      to create network sockets.
      As Android moves to eBPF for app's network data stats, access to
      /proc/net/xt_qtaguid will be removed entirely. Segmenting access off
      is the first step.
      Bug: 68774956
      
      This change also helps further segment and whitelist access to
      files in /proc/net and is a step in the lockdown of /proc/net.
      Bug: 9496886
      
      Test: boot Taimen. Walk through setup-wizard. Make phone call and
          video call. Browse web. Watch youtube. Navigate in maps.
      Test: cts-tradefed run cts -m CtsAppSecurityHostTestCases -t \
          android.appsecurity.cts.AppSecurityTests
      Test: cts-tradefed run cts -m CtsNativeNetTestCases
      Test: cts-tradefed run cts -m CtsIncidentHostTestCases -t \
          com.android.server.cts.NetstatsIncidentTest
      Test: cts-tradefed run cts -m CtsOsTestCases -t \
          android.os.cts.StrictModeTest
      Test: cts-tradefed run cts -m CtsNetTestCases -t \
          android.net.cts.TrafficStatsTest
      Test: cts-tradefed run cts -m CtsUsageStatsTestCases -t \
          android.app.usage.cts.NetworkUsageStatsTest
      Test: vts-tradefed run vts -m VtsQtaguidTest
      Change-Id: Idddd318c56b84564142d37b11dcc225a2f2800ea
      43303c8b
Loading