Skip to content
Snippets Groups Projects
Commit a5a8072f authored by Felipe Leme's avatar Felipe Leme
Browse files

Let system_server writes to dumpstate.options property.

Currently, we define 4 hardcoded init services to launch dumpstate with
different command-line options (since dumpstate must be launched by
root):

- bugreport
- bugreportplus
- bugreportwear
- bugreportremote

This approach does not scale well; a better option is to have just one
service, and let the framework pass the extra arguments through a system
property.

BUG: 31649719
Test: manual

Change-Id: I7ebbb7ce6a0fd3588baca6fd76653f87367ed0e5
parent a4567261
No related branches found
No related tags found
No related merge requests found
...@@ -170,6 +170,8 @@ allow dumpstate devpts:chr_file rw_file_perms; ...@@ -170,6 +170,8 @@ allow dumpstate devpts:chr_file rw_file_perms;
# Set properties. # Set properties.
# dumpstate_prop is used to share state with the Shell app. # dumpstate_prop is used to share state with the Shell app.
set_prop(dumpstate, dumpstate_prop) set_prop(dumpstate, dumpstate_prop)
# dumpstate_options_prop is used to pass extra command-line args.
set_prop(dumpstate, dumpstate_options_prop)
# systrace support - allow atrace to run # systrace support - allow atrace to run
allow dumpstate debugfs_tracing:dir r_dir_perms; allow dumpstate debugfs_tracing:dir r_dir_perms;
......
...@@ -2,6 +2,7 @@ type default_prop, property_type, core_property_type; ...@@ -2,6 +2,7 @@ type default_prop, property_type, core_property_type;
type shell_prop, property_type, core_property_type; type shell_prop, property_type, core_property_type;
type debug_prop, property_type, core_property_type; type debug_prop, property_type, core_property_type;
type dumpstate_prop, property_type, core_property_type; type dumpstate_prop, property_type, core_property_type;
type dumpstate_options_prop, property_type;
type persist_debug_prop, property_type, core_property_type; type persist_debug_prop, property_type, core_property_type;
type debuggerd_prop, property_type, core_property_type; type debuggerd_prop, property_type, core_property_type;
type dhcp_prop, property_type, core_property_type; type dhcp_prop, property_type, core_property_type;
......
...@@ -32,6 +32,7 @@ bluetooth. u:object_r:bluetooth_prop:s0 ...@@ -32,6 +32,7 @@ bluetooth. u:object_r:bluetooth_prop:s0
debug. u:object_r:debug_prop:s0 debug. u:object_r:debug_prop:s0
debug.db. u:object_r:debuggerd_prop:s0 debug.db. u:object_r:debuggerd_prop:s0
dumpstate. u:object_r:dumpstate_prop:s0 dumpstate. u:object_r:dumpstate_prop:s0
dumpstate.options u:object_r:dumpstate_options_prop:s0
log. u:object_r:log_prop:s0 log. u:object_r:log_prop:s0
log.tag u:object_r:log_tag_prop:s0 log.tag u:object_r:log_tag_prop:s0
log.tag.WifiHAL u:object_r:wifi_log_prop:s0 log.tag.WifiHAL u:object_r:wifi_log_prop:s0
......
...@@ -349,6 +349,7 @@ set_prop(system_server, powerctl_prop) ...@@ -349,6 +349,7 @@ set_prop(system_server, powerctl_prop)
set_prop(system_server, fingerprint_prop) set_prop(system_server, fingerprint_prop)
set_prop(system_server, device_logging_prop) set_prop(system_server, device_logging_prop)
set_prop(system_server, wifi_prop) set_prop(system_server, wifi_prop)
set_prop(system_server, dumpstate_options_prop)
userdebug_or_eng(`set_prop(system_server, wifi_log_prop)') userdebug_or_eng(`set_prop(system_server, wifi_log_prop)')
# ctl interface # ctl interface
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment