Skip to content
Snippets Groups Projects
Commit 97db27d8 authored by Christopher Wiley's avatar Christopher Wiley Committed by Mitchell Wills
Browse files

Define explicit label for wlan sysfs fwpath

avc: denied { write } for name="fwpath" dev="sysfs" ino=6863
scontext=u:r:wificond:s0 tcontext=u:object_r:sysfs_wlan_fwpath:s0
tclass=file permissive=0

Test: wificond and netd can write to this path, wifi works
Test: `runtest frameworks-wifi` passes

Bug: 29579539

Change-Id: Ia21c654b00b09b9fe3e50d564b82966c9c8e6994
(cherry picked from commit 7d13dd80)
parent 7c539b1c
No related branches found
No related tags found
No related merge requests found
...@@ -39,6 +39,8 @@ type configfs, fs_type; ...@@ -39,6 +39,8 @@ type configfs, fs_type;
type sysfs_devices_system_cpu, fs_type, sysfs_type; type sysfs_devices_system_cpu, fs_type, sysfs_type;
# /sys/module/lowmemorykiller # /sys/module/lowmemorykiller
type sysfs_lowmemorykiller, fs_type, sysfs_type; type sysfs_lowmemorykiller, fs_type, sysfs_type;
# /sys/module/wlan/parameters/fwpath
type sysfs_wlan_fwpath, fs_type, sysfs_type;
type sysfs_thermal, sysfs_type, fs_type; type sysfs_thermal, sysfs_type, fs_type;
......
...@@ -369,6 +369,7 @@ ...@@ -369,6 +369,7 @@
/sys/power/wake_unlock -- u:object_r:sysfs_wake_lock:s0 /sys/power/wake_unlock -- u:object_r:sysfs_wake_lock:s0
/sys/kernel/uevent_helper -- u:object_r:usermodehelper:s0 /sys/kernel/uevent_helper -- u:object_r:usermodehelper:s0
/sys/module/lowmemorykiller(/.*)? -- u:object_r:sysfs_lowmemorykiller:s0 /sys/module/lowmemorykiller(/.*)? -- u:object_r:sysfs_lowmemorykiller:s0
/sys/module/wlan/parameters/fwpath u:object_r:sysfs_wlan_fwpath:s0
############################# #############################
# debugfs files # debugfs files
......
...@@ -28,10 +28,14 @@ allow netd devpts:chr_file rw_file_perms; ...@@ -28,10 +28,14 @@ allow netd devpts:chr_file rw_file_perms;
# For /proc/sys/net/ipv[46]/route/flush. # For /proc/sys/net/ipv[46]/route/flush.
allow netd proc_net:file write; allow netd proc_net:file write;
# For /sys/modules/bcmdhd/parameters/firmware_path # Enables PppController and interface enumeration (among others)
# XXX Split into its own type. r_dir_file(netd, sysfs_type)
# Allows setting interface MTU
allow netd sysfs:file write; allow netd sysfs:file write;
# For /sys/modules/bcmdhd/parameters/firmware_path
allow netd sysfs_wlan_fwpath:file w_file_perms;
# TODO: added to match above sysfs rule. Remove me? # TODO: added to match above sysfs rule. Remove me?
allow netd sysfs_usb:file write; allow netd sysfs_usb:file write;
......
...@@ -9,3 +9,5 @@ binder_call(wificond, system_server) ...@@ -9,3 +9,5 @@ binder_call(wificond, system_server)
binder_call(wificond, wpa) binder_call(wificond, wpa)
allow wificond wificond_service:service_manager { add find }; allow wificond wificond_service:service_manager { add find };
allow wificond sysfs_wlan_fwpath:file w_file_perms;
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment