Commit d5e99136 authored by Simon Perkins's avatar Simon Perkins
Browse files

Fix possible deadlocks in Staging Areas.

Previously, `notify_one` was used to notify inserters and removers
waiting to insert and remove elements into the Staging Areas. This could
result in deadlock when  many removers where waiting for
different keys in the case of the MapStagingArea, or were waiting on
either peeks or get operations in the StagingArea.

For example, if two removers were waiting for keys 2 and 3 in a
MapStaging Area respectively, and 2 was inserted but only 3's remover was
notified, it is possible that 2's remover would never be notified resulting
in deadlock. Thus, both should be notified.

Similarly in the case of the StagingArea with a remover and a peeker
wanting to remove the last element and peek at a specific element
respectively, it is not clear which one should be notified due to
an insert. Thus, both should be notified.

Additionally, all inserters are now notified when an element is removed.
Consider the case where two inserters are waiting to small elements into
the Staging Area and a remover removes a single large element. As there
may be space for both insertion elements, both inserters should be
notified.
parent 84e00bf6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment