Ensure that TensorBoard is still available when pip installed. (#11835)
Context: After r1.2, TensorBoard moved out of the TensorFlow repository, into its own repository and its own pip package (presently tensorflow-tensorboard, will later switch to just tensorboard). The new pip package specifies the `tensorboard` command, so I removed it from the list of console scripts forTensorFlow. I also added tensorflow-tensorboard as a pip dependency. However, it turns out that the pip order of operations is: - install pip dependencies (thus getting tensorflow-tensorboard and the new tensorboard command) - remove deprecated console scripts (thus erroneously removing the new pointer to tensorboard) To fix this, I returned the `tensorboard` console script to tensorflow's setup.py, except it now references the tensorboard package rather than the tensorflow package. Thus, the console script declaration in tensorflow and tensorboard are identical. We can be confident that the tensorboard package is available, because it is specified by the pip dependency. Test Plan: - Create a clean virtualenv. - pip install tensorflow < 1.3. - verify that the tensorboard command works properly - pip install tensorflow 1.3 using a pip package generated with this change - verify that the tensorboard command still works
Loading
Please sign in to comment