Commit a54fdbe4 authored by Sanjoy Das's avatar Sanjoy Das Committed by TensorFlower Gardener
Browse files

Annotate C++ runtime routines with TF_ATTRIBUTE_NO_SANITIZE_MEMORY

It isn't enough to mark all the buffers we allocate as "initialized" when we
allocate them because msan also checks that the incoming argument values are
unpoisoned.

This is consistent with what we do today for FFT and Convolution already.

I also initially considered adding the memory sanitizer to the XLA pipeline, but
then realized that it would take some work to ensure that we are able to link
the sanitizer related symbols (like __msan_param_tls) in the JITed code
correctly.  So I'm punting that for now.

PiperOrigin-RevId: 206958609
parent 3a5760f2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment