linker: fix invalid zip file handling
The argument to CloseArchive has type ZipArchiveHandle, but we're passing it a ZipArchiveHandle*. The compiler doesn't detect the type mismatch because ZipArchiveHandle is a typedef for void*. Remove a duplicate close() call: The fourth argument to OpenArchiveFd is "bool assume_ownership = true". Even if the function fails, ownership of the fd is still transferred to a ZipArchive object that's deleted when this code calls CloseArchive. AFAIK, this code path is rarely or never hit. Bug: none Test: manual (eventually, 'linker64 /system!/foo') Change-Id: I95d79809b6e118fb3c39c7b98b8055c8e324db1a
Loading
Please sign in to comment