Skip to content
Snippets Groups Projects
Select Git revision
  • test default
1 result
Search by author
  • Any Author
  • CodeLinaro CodeLinaro codelinaro
  • CodeLinaro Hoperun CodeLinaro Hoperun hoperun
  • Joshua S. (Stage) Joshua S. (Stage) joshua.sickmeyer
  • Manifest Service Manifest Service manifest_service
  • Park, Jae Woo Park, Jae Woo jaewpark
5 authors
  1. Jul 23, 2020
  3. Jul 09, 2020
  5. Jun 10, 2020
  7. Mar 30, 2020
  9. Mar 27, 2020
  11. Jan 18, 2020
  13. Dec 25, 2019
  15. Dec 18, 2019
  17. Oct 25, 2019
  19. Oct 02, 2019
  21. Sep 21, 2019
  23. Sep 19, 2019
  25. Sep 18, 2019
    • Paul Lawrence's avatar
      Fix crash in mainline · 1b535e41
      Paul Lawrence authored 
      Current behavior:

Assume not checkpointing
cp_startCheckpoint creates the file in metadata
cp_needsCheckpoint will now set isCheckpointing to true
cp_commitCheckpoint will now think there is a checkpoint, and try to
commit it. This will fail on ext4 and it will return false, leading to
bad things.

cp_startCheckpoint is called when staging an apex module for update.
After this point, several things could go wrong:

If a keystore key is deleted, it calls cp_needsCheckpoint to see if the
delete should be deferred until cp_commitCheckpoint. The delete will now
be deferred, meaning that this key will never be deleted, using up the
key sots in trustzone

If a trim is scheduled through idle maintenance, this also calls
cp_needsCheckpoint, so the trims will not occur.

If either of these happens before a system crash, the device will not
recover since the system calls commitCheckpoint which will now crash.

When the system then goes on to reboot, the checkpoint will not be
triggered, since the commitCheckpoint call will have deleted the
checkpoint flag file before crashing.

Bug: 138952436
Test: vdc checkpoint startCheckpoint 5
      vdc checkpoint needsCheckpoint
      vdc checkpoint commitChanges
      stop;start

      commitChanges fails, then device loops

      After applying this test, commitChanges succeeds and device does
      not loop

Change-Id: I135099625f77344d1f8d2e8688735871c44ef2f5
Merged-In: I135099625f77344d1f8d2e8688735871c44ef2f5
      1b535e41
  27. Sep 17, 2019
    • Paul Crowley's avatar
      Create a per-boot key on each boot · ccc84dec
      Paul Crowley authored 
      Bug: 140882488
Test: Booted twice, checked logs to ensure encryption
    is different each time, adb created files in directory.
Cherry-Picked-From: c8a3ef3f3c501c7bc14a2078dde513765cdb56d7
Merged-In: I74077bf8f727dab726c25f512ed7406a74cbe0bf
Change-Id: I74077bf8f727dab726c25f512ed7406a74cbe0bf
      ccc84dec
  29. Sep 11, 2019
  31. Aug 13, 2019
  33. Aug 12, 2019
  35. Aug 08, 2019
  37. Jul 20, 2019
  39. Jul 19, 2019
  41. Jul 18, 2019
    • Gaurav Kashyap's avatar
      system: vold: Use ICE for UFS card · 38cbb943
      Gaurav Kashyap authored 
      Identify UFS Card while mounting during adoptable
storage, and use ICE for encryption/decryption if
it is the case as compared to software encryption
being used for SD card.

CRs-Fixed: 2491182

Change-Id: Iea7e34b06e3ceab8e292ac14d5115566382609ab
      38cbb943
  43. Jul 17, 2019
  45. Jul 16, 2019
  47. Jul 11, 2019
  49. Jul 08, 2019
  51. Jul 05, 2019
  53. Jul 03, 2019
  55. Jul 01, 2019
  57. Jun 29, 2019
  59. Jun 28, 2019