Update expectations of CpuFeatures.isAESHardwareAccelerated for 32bit x86.
Despite its name isAESHardwareAccelerated is used in assertions in StandardNames.java to determine whether to expect hardware AES acceleration is available and so to determine the default list of cyphers to expect from Conscrypt. I haven't renamed it in this CL but it might make sense to do so. b/112830137 was due to this method expecting hardware AES acceleration to be available when running on any x86 CPU where /proc/cpuinfo reports the "aes" flag. However this is *not* the case when running in a 32bit VM, which was causing CTS failures on 32bit x86 builds. Note that 32bit x86 is not a supported platform for Conscrypt, so it doesn't realy make sense to add an equivalent change to the CpuFeatures.java in Conscript's libcore-stub. Bug: 112830137 Test: cts -m CtsLibcoreTestCases on both ARM and x86 targets Change-Id: I4a2643082aa3a638106a77f6916cc3329498e58f
Loading
Please sign in to comment