Commit 5558171b authored by Neil Fuller's avatar Neil Fuller
Browse files

Remove a race hazard from the execrable Support_TestWebServer

Use of this class was resulting in threads being left in a
spinning state due to the accept socket being closed but
"running" still being true: the exception thrown from
Socket.accept() was being swallowed.

This is likely because there is a race between the thread
actually starting (i.e. run() actually executing)
and, in short-lived tests, the server being shutdown:
if AcceptThread.close() was called before AcceptThread.run()
then when run() actually executed it would loop forever.

Some dead code has been removed.

Test: Ran the CTS tests
Bug: 29820565
Change-Id: I92cc8b150378bb41f49f996422e1a7bc19801b67
parent 03aae052
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment