Skip to content
Snippets Groups Projects
  1. Mar 30, 2017
  2. Mar 29, 2017
  3. Mar 28, 2017
    • Pierre Lorinquer's avatar
      Fix EAP_MD5 "len" field computation. · 2cd6d334
      Pierre Lorinquer authored
      The default values of the "value_size" field is None. This can trigger
      an issue
      when computing the "len" field.
      
      Test: str(EAP_MD5())
      
      In order to fix this issue, the default value of the "value_size" field
      has been set to 0.
      
      Tests have been added in "regression.uts".
      
      Added regression tests for EAP_TLS and EAP_FAST.
      
      Use XStrLenField in EAP_MD5, EAP_TLS and EAP_FAST packets instead of StrLenField.
      
      Delete blank lines before the class description (EAPOL, EAP, EAP_MD5, EAP_TLS and EAP_FAST packet classes).
      
      "registered_options" dictionary was renamed "registered_methods"
      (EAP-MD5, EAP-TLS etc are not options, but authentication methods).
      
      EAP getlayer() and haslayer() methods have been overloaded in order to
      allow access to a given "EAP layer" (such as EAP_TLS, for instance) by
      providing the parent class name ("EAP"). For example, this is now
      possible:
      
      >>> eap_tls = EAP_TLS()
      >>> EAP_TLS in eap_tls
      True
      >>> EAP in eap_tls
      True
      >>> eap_tls[EAP_TLS]
      <EAP_TLS  |>
      >>> eap_tls[EAP]
      <EAP_TLS  |>
      
      Regression tests have been added.
      2cd6d334
    • Thomas Faivre's avatar
      layers/tls: fix shell start with old cryptography · b40f1fca
      Thomas Faivre authored
      
      Seen on Redhat-7 with distribution version of python-cryptography
      (1.3.1):
        File "/usr/lib/python2.7/site-packages/scapy/layers/tls/crypto/ffdh.py", line 207, in <module>
          params = pn.parameters(default_backend())
      AttributeError: 'DHParameterNumbers' object has no attribute 'parameters'
      
      This is due to an API change in cryptography 1.7 which is the required version
      for scapy. Althought, we should still be able to launch the shell.
      
      Check if cryptography is valid before filling FFDH_GROUPS.
      
      Signed-off-by: default avatarThomas Faivre <thomas.faivre@6wind.com>
      b40f1fca
    • Thomas Faivre's avatar
      layers/ipsec: fix AH dissection · c73cdbc5
      Thomas Faivre authored
      
      The ICV size is defined by the authentication algorithm in the SA.
      it can be deduced from the payloadlen field but the padding len is
      unknown aswell so there is no way to find both without the SA.
      
      Assume everything in payloadlen is the ICV until the verification called
      from the SA. Fill padding when possible.
      
      Signed-off-by: default avatarThomas Faivre <thomas.faivre@6wind.com>
      c73cdbc5
  4. Mar 27, 2017
  5. Mar 24, 2017
  6. Mar 23, 2017
    • gpotter2's avatar
      Fix automaton tests · fddf6573
      gpotter2 authored
      fddf6573
    • Guillaume Valadon's avatar
      Small fix and unit tests · 1ab629e4
      Guillaume Valadon authored
      1ab629e4
    • Klement Sekera's avatar
      MPLS - improve payload guess · c6652993
      Klement Sekera authored
      c6652993
    • Klement Sekera's avatar
      DHCP6 - support additional options · 272e3bb7
      Klement Sekera authored
      272e3bb7
    • Klement Sekera's avatar
      GRE - fix layer binding · 38960ace
      Klement Sekera authored
      38960ace
    • Pierre Lalet's avatar
      Merge pull request #575 from 6WIND/gitversion-fix · 75aa97f1
      Pierre Lalet authored
      Only read version from git when in scapy
      75aa97f1
    • Ján Sebechlebský's avatar
      Fix EAP (#557) · c2333696
      Ján Sebechlebský authored
      * Add message field in EAP-Indentity request
      
      EAP-Identity request may contain message as stated in RFC3748.
      
      * Fix fragmented EAP-TLS
      
      Current implementation fails to dissect fragmented EAP-TLS.
      Fragmented EAP-TLS messages are quite common, in this case only
      first EAP-TLS will contain tls_message_len field (indicated by L bit),
      which will be total length of reassembled tls message.
      
      Length of tls payload in single EAP-TLS message should therefore
      be determined by EAP.len field (see RFC5216-Fragmentation).
      
      To implement this I find reasonable to make EAP-TLS subclass of EAP.
      
      * Fix fragmented EAP-FAST
      
      Implementation of EAP-FAST suffers from the same issue as EAP-TLS,
      see previous commit message.
      
      * Fix EAP-MD5 Dissection
      
      Implementation of EAP-MD5 was not following RFC3748 (which is
      referencing RFC1994) properly.
      
      Field value_size is determining only size of value_field.
      It might have length different than 16B in EAP-MD5 request,
      because in that case it is not used to transmit MD5 hash,
      but random challenge value.
      Size of optional_name(extra data) is determined as "rest of" EAP message
      (len field of EAP).
      c2333696
    • Robin Jarry's avatar
      Only read version from git when in scapy · 4584f36a
      Robin Jarry authored
      
      Scapy may be used as third party library by other projects, themselves
      managed under git. This leads to surprising results such as this:
      
          $ git describe
          awesomeproject-v5.22-1-ga1316614c290
          $ virtualenv env
          ...
          $ . env/bin/activate
          (env)$ pip install scapy==2.3.3
          ...
          (env)$ cat env/lib/python2.7/site-packages/scapy/VERSION
          2.3.3
          (env)$ which scapy
          /home/.../env/bin/scapy
          (env)$ scapy
          ...
          Welcome to Scapy (awesomeproject-v5.22.dev1)
          >>>
      
      Scapy's version is wrongly set to the current project's version.
      
      When trying to determine scapy's version from git, make sure that the
      code is executed from the root of a git repo. If not, read the version
      from the scapy/VERSION file which has been generated when packaging
      scapy source archive.
      
      Fixes: 4f71027f ("enhance version management")
      Signed-off-by: default avatarRobin Jarry <robin.jarry@6wind.com>
      4584f36a
  7. Mar 22, 2017
  8. Mar 21, 2017
  9. Mar 20, 2017
  10. Mar 17, 2017
  11. Mar 16, 2017
  12. Mar 15, 2017
Loading