Merge pull request #152 from sieben/list_literal

List literal

scapy/arch/winpcapy.py

@@ -148,10 +148,7 @@ class pcap_stat(Structure):
     pass
 ### _fields_ list in Structure is final.
 ### We need a temp list
-_tmpList=[]
-_tmpList.append(("ps_recv",c_uint))
-_tmpList.append(("ps_drop",c_uint))
-_tmpList.append(("ps_ifdrop",c_uint))
+_tmpList = [("ps_recv", c_uint), ("ps_drop", c_uint), ("ps_ifdrop", c_uint)]
 if HAVE_REMOTE:
     _tmpList.append(("ps_capt",c_uint))
     _tmpList.append(("ps_sent",c_uint))

scapy/contrib/ldp.py

@@ -226,8 +226,7 @@ class CommonHelloTLVField(StrField):
 class CommonSessionTLVField(StrField):
     islist = 1
     def m2i(self, pkt, x):
-        l = []
-        l.append(struct.unpack("!H",x[6:8])[0])
+        l = [struct.unpack("!H", x[6:8])[0]]
         octet = struct.unpack("B",x[8:9])[0]
         l.append( (octet & 2**7 ) >> 7 )
         l.append( (octet & 2**6 ) >> 6 )