Commit 592bf711 authored by Jeremy Compostella's avatar Jeremy Compostella Committed by Elliott Hughes
Browse files

Revert "Add 64-bit slm optimized strlcpy and srlcat."

This reverts commit 2e7145c0.

When src is at the end page, the sse2 strlcpy SSE2 optimized version
can issue a movdqu instruction that can cross the page boundary.  If
the next page is not allocated to that process, it leads to
segmentation fault.  This is a rare but has be caught multiple times
during robustness testing.

We isolated a way to reproduce that issue outside of an Android device
and we have been able to resolve this particular case.  However, we
ran some additional compliance and robustness tests and found several
other similar page crossing issues with this implementation.

In conclusion, this optimization needs to be re-written from scratch
because its design is at cause.  In the meantime, it is better to
remove it.

Bug: http://b/78355649


Change-Id:  If90450de430ba9b7cd9282a422783beabd701f3d
Signed-off-by: default avatarJeremy Compostella <jeremy.compostella@intel.com>

(cherry picked from commit 611ad621)
parent 4c9504aa
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment