Commit 7341763c authored by Alistair Strachan's avatar Alistair Strachan Committed by Steve Muckle
Browse files

Enable more options required as dependencies.



(p/ directory version)

When verifying the android-base and android-recommended configurations,
it is useful to start from as minimal a kernel config as possible. The
most minimal config is "allnoconfig".

However, the "allnoconfig" experiment highlights a design problem with
these kernel config fragments. The 'depends' for the options we want to
turn on won't be turned on if the defconfig used as the first parameter
to scripts/kconfig/merge_config.sh forcibly turned them off, even if the
options were 'default y' or 'default m'.

So, rather than relying on somebody running the merge_config.sh having
the 'depends' set favorably for dependent options, explicitly define all
of the dependencies with =y. When testing with an "allnoconfig", which
is a worst-case scenario, all of the 'base' and 'recommended' options
are now turned on correctly.

android-base.cfg:

CONFIG_ADVISE_SYSCALLS=y   bionic: madvise, posix_madvise, etc.
CONFIG_BLOCK=y             CONFIG_EXT4_FS, CONFIG_F2FS_FS
CONFIG_EPOLL=y             bionic: epoll_create, etc.
CONFIG_EVENTFD=y           bionic: eventfd etc.
CONFIG_FUTEX=y             bionic: __futex_wait, __futex_wake.
CONFIG_PROC_FS=y           bionic: linker, pthread, etc.
CONFIG_PROFILING=y         CONFIG_UID_SYS_STATS (missing only on 3.18)
CONFIG_SHMEM=y             CONFIG_ASHMEM
CONFIG_SIGNALFD=y          bionic: signalfd, signalfd64, etc.
CONFIG_SUSPEND=y           CONFIG_PM_SLEEP via CONFIG_PM_WAKELOCKS.
CONFIG_SYSFS=y             bionic: sysinfo, selinux
CONFIG_TIMERFD=y           bionic: timerfd_create, etc.
CONFIG_USB_SUPPORT=y       CONFIG_USB_GADGET

android-recommended.cfg:

CONFIG_CONFIGFS_FS=y       CONFIG_SDCARD_FS
CONFIG_GPIOLIB=y           CONFIG_ANDROID_TIMED_GPIO (only 3.18, 4.4)
CONFIG_HID_GENERIC=y       "Support for generic devices on the HID bus"
CONFIG_KALLSYMS=y          CONFIG_KALLSYMS_ALL
CONFIG_KEYS=y              CONFIG_ASYMMETRIC_KEY_TYPE
CONFIG_MISC_FILESYSTEMS=y  fs/pstore/Kconfig

Bug: 79875143
Change-Id: I213bd0c540747892084edc583bd46997943e9f9b
Merged-In: Ifb76ee5883ff5541771e9a951c055b99fd09e029
Signed-off-by: default avatarAlistair Strachan <astrachan@google.com>
parent 44023958
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment