Commit 66b8787f authored by Michael Anthony Knyszek's avatar Michael Anthony Knyszek Committed by Andrew Bonventre
Browse files

[release-branch.go1.13] runtime: scavenge on growth instead of inline with allocation

Inline scavenging causes significant performance regressions in tail
latency for k8s and has relatively little benefit for RSS footprint.

We disabled inline scavenging in Go 1.12.5 (CL 174102) as well, but
we thought other changes in Go 1.13 had mitigated the issues with
inline scavenging. Apparently we were wrong.

This CL switches back to only doing foreground scavenging on heap
growth, rather than doing it when allocation tries to allocate from
scavenged space.

Fixes #34556

Change-Id: I1f5df44046091f0b4f89fec73c2cde98bf9448cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/183857


Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: default avatarKeith Randall <khr@golang.org>
Reviewed-by: default avatarMichael Knyszek <mknyszek@google.com>
(cherry picked from commit eb96f8a5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/198486


Reviewed-by: default avatarAustin Clements <austin@google.com>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
parent cd951aee
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment