Commit 5ebdfd90 authored by Keith Randall's avatar Keith Randall Committed by Carlos Amedee
Browse files

[release-branch.go1.13] cmd/compile: don't addLocalInductiveFacts if there is...

[release-branch.go1.13] cmd/compile: don't addLocalInductiveFacts if there is no direct edge from if block to phi block

Currently in addLocalInductiveFacts, we only check whether
direct edge from if block to phi block exists. If not, the
following logic will treat the phi block as the first successor,
which is wrong.

This patch makes prove pass more conservative, so we disable
some cases in test/prove.go. We will do some optimization in
the following CL and enable these cases then.

Fixes #40500.

Change-Id: I27cf0248f3a82312a6f7dabe11c79a1a34cf5412
Reviewed-on: https://go-review.googlesource.com/c/go/+/244579


Reviewed-by: default avatarZach Jones <zachj1@gmail.com>
Reviewed-by: default avatarKeith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/245957


Reviewed-by: default avatarDavid Chase <drchase@google.com>
Reviewed-by: default avatarCarlos Amedee <carlos@golang.org>
parent d3ba9416
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment