Commit 437bd90f authored by Bryan C. Mills's avatar Bryan C. Mills
Browse files

cmd/go/internal/base: rename EnvForDir to AppendPWD

EnvForDir does not immediately evoke “append”, and thus may not prompt
the reader to consider the possibility of aliasing bugs (as in
issue #38077). To make this behavior more obvious at the call site, rename
cmd/go/internal/base.EnvForDir to AppendPWD and swap the order of
arguments to a conventional “append” function (similar to those in the
strconv package).

For #38077

Change-Id: I16f09aa0fa8a269d51f0511eb402a44e2759eb94
Reviewed-on: https://go-review.googlesource.com/c/go/+/225578


Reviewed-by: default avatarJay Conrod <jayconrod@google.com>
Reviewed-by: default avatarMichael Matloob <matloob@golang.org>
parent bfb1342a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment