cmd/compile: fix incoming ABI with GOEXPERIMENT=regabiargs
When regabiargs is enabled, a function's incoming ABI should be determined solely by the function's own definition ABI (which is usually ABIInternal, but can be ABI0 for ABI wrappers). For example, the current code miscompiles ABI0 -> ABIInternal wrappers when the experiment is enabled because it treats the wrapper itself as being called as ABIInternal. This causes it to assume the incoming arguments are already in registers, so usually the wrapper doesn't do anything with the arguments because it thinks they're already in the right place. With this fix, these wrappers now correctly load the arguments from the stack and put them in registers. For #40724. Change-Id: Iec784e88ebc55d9e95e830ed7533aa336f3b1ca2 Reviewed-on: https://go-review.googlesource.com/c/go/+/306409 Trust: Austin Clements <austin@google.com> Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by:Than McIntosh <thanm@google.com> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
Loading
Please sign in to comment