runtime/pprof: try to use real stack in TestTryAdd
TestTryAdd is particularly brittle because it tests some real cases by constructing fake sample stack frames. If those frames don't correctly represent what the runtime would generate then they may fail to catch regressions. Instead, call runtime.Callers at the bottom of real function calls to generate real frames as a base for truncation, etc in tests. Several of these tests still have to fake parts of the frames to test the right thing, but this is a bit less fragile. Change-Id: I62522a9ded5544b06d1bf28550af5400f3af667b Reviewed-on: https://go-review.googlesource.com/c/go/+/227484 Run-TryBot: Michael Pratt <mpratt@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:Hyang-Ah Hana Kim <hyangah@gmail.com>
Loading
Please sign in to comment