Commit 704d5cb1 authored by Philipp Rudo's avatar Philipp Rudo Committed by Kazuhito Hagio
Browse files

[PATCH 14/15] remove variable length array in write_kdump_pages_and_bitmap_cyclic()



Variable length arrays can be problematic. For example with C11 they got
downgraded to an optional feature and thus might not be supported in all
environments. Furthermore they don't allow error checks whether the
allocation succeeded. If it fails this causes undefined behavior. This is
especially problematic when its size is read from a dump, like it is done
for info->page_size, as it might have been corrupted. Thus get rid of
variable length arrays and allocate them on the heap instead.

Signed-off-by: default avatarPhilipp Rudo <prudo@redhat.com>
parent 1424682d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment