From d92076d930af11bb9a3025a6b2f12ca139c0436f Mon Sep 17 00:00:00 2001
From: Mike Frysinger <vapier@google.com>
Date: Sun, 9 Feb 2020 16:20:06 -0500
Subject: [PATCH] Revert "Save cookies back to jar when fetching clone.bundle"
This reverts commit 4abf8e6ef81e78469148b156ae2d2da70ace627a.
The curl process for updating the cookie file is not atomic. When
fetching many bundles in parallel, we can sometimes corrupt the file
causing it to be cleared. Since users should manage gitcookies on
their own, leave it read-only.
Bug: https://crbug.com/gerrit/12300
Change-Id: Id472c99b197bc4cf8533c649f8881509f38643c1
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254092
Reviewed-by: David Pursehouse <dpursehouse@collab.net>
Tested-by: Mike Frysinger <vapier@google.com>
(cherry picked from commit dc1d0e0c7fffa5109048ac52a67aa97bb362ae3a)
---
project.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/project.py b/project.py
index 77b97f7..8fdacc6 100644
--- a/project.py
+++ b/project.py
@@ -2398,7 +2398,7 @@ class Project(object):
platform_utils.remove(tmpPath)
with GetUrlCookieFile(srcUrl, quiet) as (cookiefile, proxy):
if cookiefile:
- cmd += ['--cookie', cookiefile, '--cookie-jar', cookiefile]
+ cmd += ['--cookie', cookiefile]
if proxy:
cmd += ['--proxy', proxy]
elif 'http_proxy' in os.environ and 'darwin' == sys.platform:
--
GitLab