From 76b7f7b3111b0c1bf73a21c296ee696dba8b0687 Mon Sep 17 00:00:00 2001
From: Dan Willemsen <dwillemsen@google.com>
Date: Tue, 8 May 2018 17:10:03 -0700
Subject: [PATCH] Remove unused `tags` property from Android.bp files
The tags property is (and has always been) unused by Soong. The property has
been defined as a list of strings, and the `androidmk` converted any
LOCAL_MODULE_TAGS entries over to it, but we've never done anything with it.
In preparation for removing the definition from Soong, I'm removing it from all
Android.bp files in the tree.
Since this has never done anything, this is a no-op, but if you really did want
the Android.mk behavior, the proper way to define a module to be installed in
userdebug / eng builds is to use PRODUCT_PACKAGES_DEBUG or PRODUCT_PACKAGES_ENG
in the appropriate product makefile.
Change-Id: Ia9a9b1c35533e02047cbb183b317ab93f1eeec6b
Exempt-From-Owner-Approval: global no-op build change
Test: remove `tags` from Soong, see errors go away.
---
tools/Android.bp | 2 --
tools/fc_sort/Android.bp | 1 -
2 files changed, 3 deletions(-)
diff --git a/tools/Android.bp b/tools/Android.bp
index 818430264..2809c9d25 100644
--- a/tools/Android.bp
+++ b/tools/Android.bp
@@ -22,7 +22,6 @@ cc_defaults {
],
static_libs: ["libsepol"],
stl: "none",
- tags: ["optional"],
}
cc_binary_host {
@@ -55,6 +54,5 @@ cc_binary_host {
cc_prebuilt_binary {
name: "insertkeys.py",
srcs: ["insertkeys.py"],
- tags: ["optional"],
host_supported: true,
}
diff --git a/tools/fc_sort/Android.bp b/tools/fc_sort/Android.bp
index acecc9707..d0a391be3 100644
--- a/tools/fc_sort/Android.bp
+++ b/tools/fc_sort/Android.bp
@@ -18,7 +18,6 @@ cc_binary_host {
name: "fc_sort",
srcs: ["fc_sort.c"],
stl: "none",
- tags: ["optional"],
cflags: [
"-Wall",
"-Werror",
--
GitLab