From 57d66ef1c2d38346399fc1145b1602a7775d41f7 Mon Sep 17 00:00:00 2001
From: liwugang <liwugang@xiaomi.com>
Date: Wed, 14 Nov 2018 16:39:39 +0800
Subject: [PATCH] Fix the bound size and the variable name
It will not end when other words appeared because of the wrong bound and variable,
rule_map->length will exceed the actual length in the rule_map_new function,
it will lead to crash in the rule_map_validate function because of strcmp(NULL, str).
Test: 1.add "user=shell doman=system_app" to private/seapp_contexts
2.exec "checkseapp private/seapp_contexts" and it will not be crashed
Change-Id: I600206448b38cf2c9b61f9141b40f920b05696c8
Signed-off-by: liwugang <liwugang@xiaomi.com>
---
tools/check_seapp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/check_seapp.c b/tools/check_seapp.c
index 1022cbd48..a7de7a2d2 100644
--- a/tools/check_seapp.c
+++ b/tools/check_seapp.c
@@ -742,7 +742,7 @@ static rule_map *rule_map_new(kvp keys[], size_t num_of_keys, int lineno,
/* Only assign key name to map name */
if (strcasecmp(k->key, x->name)) {
- if (i == KVP_NUM_OF_RULES) {
+ if (j == KVP_NUM_OF_RULES - 1) {
log_error("No match for key: %s\n", k->key);
goto err;
}
--
GitLab