From 9ad7f414d779afa6e193423774e6891206107e23 Mon Sep 17 00:00:00 2001
From: Sarangdhar Joshi <spjoshi@codeaurora.org>
Date: Mon, 31 Aug 2015 15:40:57 -0700
Subject: [PATCH] lrdpv2: Fix list vs tuple comparison
The ram_dump.kernel_version variable is defined as a list and
incorrectly compared with tuple. This comparison always fails.
Fix it by changing ram_dump.kernel_version variable to tuple.
Change-Id: I12d4556693101fccfad795e5ea737b42e96acac7
---
linux-ramdump-parser-v2/ramdump.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-ramdump-parser-v2/ramdump.py b/linux-ramdump-parser-v2/ramdump.py
index e1b779f..27af4a2 100644
--- a/linux-ramdump-parser-v2/ramdump.py
+++ b/linux-ramdump-parser-v2/ramdump.py
@@ -472,7 +472,7 @@ class RamDump():
self.ipc_log_debug = options.ipc_debug
self.ipc_log_help = options.ipc_help
self.use_stdout = options.stdout
- self.kernel_version = [0, 0, 0]
+ self.kernel_version = (0, 0, 0)
if options.ram_addr is not None:
# TODO sanity check to make sure the memory regions don't overlap
for file_path, start, end in options.ram_addr:
@@ -640,7 +640,7 @@ class RamDump():
self.version = v.group(1)
match = re.search('(\d+)\.(\d+)\.(\d+)', self.version)
if match is not None:
- self.kernel_version = map(int, match.groups())
+ self.kernel_version = tuple(map(int, match.groups()))
else:
print_out_str('!!! Could not extract version info! {0}'.format(self.version))
--
GitLab