diff --git a/StandAlone/StandAlone.cpp b/StandAlone/StandAlone.cpp index 0a8f395fea7b94f6924dc9d4d7cf9529d22e8676..0c54273e034f3d28dbeeaa36c1e13ad593753443 100644 --- a/StandAlone/StandAlone.cpp +++ b/StandAlone/StandAlone.cpp @@ -412,7 +412,26 @@ void StderrIfNonEmpty(const char* str) struct ShaderCompUnit { EShLanguage stage; std::string fileName; - char** text; // memory owned/managed externally + char** text; // memory owned/managed externally + const char* fileNameList[1]; + + //Need to have a special constructors to adjust the fileNameList, since back end needs a list of ptrs + ShaderCompUnit(EShLanguage istage, std::string &ifileName, char** itext) + { + stage = istage; + fileName = ifileName; + text = itext; + fileNameList[0] = fileName.c_str(); + } + + ShaderCompUnit(const ShaderCompUnit &rhs) + { + stage = rhs.stage; + fileName = rhs.fileName; + text = rhs.text; + fileNameList[0] = fileName.c_str(); + } + }; // @@ -439,7 +458,7 @@ void CompileAndLinkShaderUnits(std::vector<ShaderCompUnit> compUnits) for (auto it = compUnits.cbegin(); it != compUnits.cend(); ++it) { const auto &compUnit = *it; glslang::TShader* shader = new glslang::TShader(compUnit.stage); - shader->setStrings(compUnit.text, 1); + shader->setStringsWithLengthsAndNames(compUnit.text, NULL, compUnit.fileNameList, 1); if (entryPointName) // HLSL todo: this needs to be tracked per compUnits shader->setEntryPoint(entryPointName); shaders.push_back(shader); diff --git a/hlsl/hlslParseHelper.cpp b/hlsl/hlslParseHelper.cpp index 2a793759a6d14242c7616bef73334b650f16c8ff..2662ea049df21eb21e6a01f3327e3d32579d47e7 100755 --- a/hlsl/hlslParseHelper.cpp +++ b/hlsl/hlslParseHelper.cpp @@ -116,9 +116,12 @@ bool HlslParseContext::parseShaderStrings(TPpContext& ppContext, TInputScanner& HlslScanContext scanContext(*this, ppContext); HlslGrammar grammar(scanContext, *this); - if (! grammar.parse()) - printf("HLSL translation failed.\n"); - + if (!grammar.parse()) + { + //Print out a nicer error message that should be formated such that if you click on the message it will take you right to the line through most UIs + const glslang::TSourceLoc& sourceLoc = input.getSourceLoc(); + printf("\n%s(%i): error at column %i, HLSL translation failed.\n", sourceLoc.name, sourceLoc.line, sourceLoc.column); + } return numErrors == 0; }